Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glitch when dismissing a GIF in the media attachment viewer #6475

Closed
mgcm opened this issue Jul 26, 2022 · 1 comment · Fixed by #6476
Closed

Glitch when dismissing a GIF in the media attachment viewer #6475

mgcm opened this issue Jul 26, 2022 · 1 comment · Fixed by #6476
Labels
A-Media A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@mgcm
Copy link
Contributor

mgcm commented Jul 26, 2022

Steps to reproduce

Description

In the Media Attachment Viewer there is a glitch when dismissing an animated GIF - the WebView which shows the GIF animation still shows in the background while the transition interaction is occurring.

Steps to Reproduce

  1. Open a room or 1-1 chat
  2. Share a GIF animation
  3. Tap the GIF image in the channel timeline to preview it in full screen
  4. What it animate
  5. Dismiss it by dragging
  6. You will see the image preview follow your gesture but below the animation is still showing

Video clip of bug

gif-webview-glitch.mp4

Outcome

What did you expect?

The animation should not show below when the dismissal animation is occurring.

What happened instead?

See the description.

Your phone model

No response

Operating system version

No response

Application version

develop

Homeserver

No response

Will you send logs?

No
@mgcm mgcm added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jul 26, 2022
@mgcm
Copy link
Contributor Author

mgcm commented Jul 26, 2022

I will be submitting a pull request with a fix for this in a few minutes.

@mgcm mgcm mentioned this issue Jul 26, 2022
Merged
8 tasks
@pixlwave pixlwave added A-Timeline A-Media S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 1, 2022
pixlwave pushed a commit that referenced this issue Aug 5, 2022
@mgcm
Fixes a glitch when dismissing a GIF in the media attachment viewer (#…
6cb076b 
…6475) (#6476)

* Fixed a glitch in media viewer when dismissing a GIF: the WebView which shows the animation would show in the background while the transition interaction occurred

* adding the changelog entry

Signed-off-by: Milton Moura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Media A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes a glitch when dismissing a GIF in the media attachment viewer (#6475) mgcm/element-ios
2 participants
@mgcm @pixlwave