-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read tile server URL from .well-known (PSG-592) #6472
Conversation
Signed-off-by: Johannes Marbach <[email protected]>
Signed-off-by: Johannes Marbach <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #6472 +/- ##
===========================================
- Coverage 6.23% 6.21% -0.03%
===========================================
Files 1453 1453
Lines 155799 155811 +12
Branches 62599 62600 +1
===========================================
- Hits 9718 9684 -34
- Misses 145675 145725 +50
+ Partials 406 402 -4
Continue to review full report at Codecov.
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/nYWnoF |
Signed-off-by: Johannes Marbach <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
@@ -382,7 +386,8 @@ final class RoomCoordinator: NSObject, RoomCoordinatorProtocol { | |||
matrixItemId: user.userId, | |||
displayName: user.displayname) | |||
|
|||
let parameters = LocationSharingCoordinatorParameters(roomDataSource: roomViewController.roomDataSource, | |||
let parameters = LocationSharingCoordinatorParameters(session: mxSession, | |||
roomDataSource: roomViewController.roomDataSource, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: In fact in the LocationSharingCoordinatorParameters
we are grabbing the mxSession
from the roomDataSource
but it's clearer to inject directly the mxSession
Signed-off-by: Johannes Marbach [email protected]
Pull Request Checklist