Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read tile server URL from .well-known (PSG-592) #6472

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Jul 25, 2022

Signed-off-by: Johannes Marbach [email protected]

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #6472 (234e25c) into develop (4a1ec4d) will decrease coverage by 0.02%.
The diff coverage is 3.33%.

@@             Coverage Diff             @@
##           develop    #6472      +/-   ##
===========================================
- Coverage     6.23%    6.21%   -0.03%     
===========================================
  Files         1453     1453              
  Lines       155799   155811      +12     
  Branches     62599    62600       +1     
===========================================
- Hits          9718     9684      -34     
- Misses      145675   145725      +50     
+ Partials       406      402       -4     
Impacted Files Coverage Δ
Config/BuildSettings.swift 42.18% <ø> (ø)
Riot/Modules/Room/RoomCoordinator.swift 0.00% <0.00%> (ø)
...dinator/LiveLocationSharingViewerCoordinator.swift 0.00% <0.00%> (ø)
...aring/Coordinator/LocationSharingCoordinator.swift 0.00% <0.00%> (ø)
...Coordinator/StaticLocationViewingCoordinator.swift 0.00% <0.00%> (ø)
...Configuration/HomeserverConfigurationBuilder.swift 88.28% <100.00%> (ø)
...SplashScreen/OnboardingSplashScreenViewModel.swift 11.53% <0.00%> (-42.31%) ⬇️
...Modules/Common/ViewModel/StateStoreViewModel.swift 30.55% <0.00%> (-19.45%) ⬇️
Config/CommonConfiguration.swift 85.71% <0.00%> (-5.20%) ⬇️
Riot/Managers/Call/CallPresenter.swift 1.08% <0.00%> (-5.14%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a1ec4d...234e25c. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 25, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/nYWnoF

Signed-off-by: Johannes Marbach <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -382,7 +386,8 @@ final class RoomCoordinator: NSObject, RoomCoordinatorProtocol {
matrixItemId: user.userId,
displayName: user.displayname)

let parameters = LocationSharingCoordinatorParameters(roomDataSource: roomViewController.roomDataSource,
let parameters = LocationSharingCoordinatorParameters(session: mxSession,
roomDataSource: roomViewController.roomDataSource,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: In fact in the LocationSharingCoordinatorParameters we are grabbing the mxSession from the roomDataSource but it's clearer to inject directly the mxSession

@Johennes Johennes merged commit 6ae2206 into develop Jul 26, 2022
@Johennes Johennes deleted the johannes/tile-server-well-known branch July 26, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants