Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location sharing is missing OpenStreetMap attribution #5609

Closed
habi opened this issue Feb 16, 2022 · 6 comments
Closed

Location sharing is missing OpenStreetMap attribution #5609

habi opened this issue Feb 16, 2022 · 6 comments
Assignees
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@habi
Copy link

habi commented Feb 16, 2022

As an avid OpenStreetMap contributor, I am pleased to see that you are using OpenStreetMap for the new location sharing feature.

However, I noticed that the map seems to lack the proper credit.
OpenStreetMap's license requires that you both credit OpenStreetMap and make users aware of the data license (by linking to our copyright page).

For more information, see: https://www.openstreetmap.org/copyright

The correct attribution helps to avoid misunderstandings about the source of the map or data, as well as what others are allowed to do with it. If you need help making the changes or have further questions, feel free to ask in one of OpenStreetMap's communication channels: https://wiki.openstreetmap.org/wiki/Contact

More importantly attribution helps us spread the word about OpenStreetMap and attract new contributors and build the community.
This is incredibly important to improving the quality of the database that you and millions of others rely on.

@habi
Copy link
Author

habi commented Feb 16, 2022

Here's a screenshot from iOS.

image

@habi
Copy link
Author

habi commented Feb 16, 2022

Further, when the message is clicked, the share button on top (see screenshot) links to https://maps.apple.com?ll=$REDACTED_LAT,$REDACTED_LON&q=Pin

image

@stefanceriu
Copy link
Member

Hi David, thank you for raising a ticket about this. This is a miss on our part and will add it asap 👍

As for your second comment, I'm note entirely sure what you mean. That textual representation is there to make the share sheet show a pretty thumbnail but also to force apple maps to drop a pin when you open it. Would you have preffered a different format?

@stefanceriu stefanceriu self-assigned this Feb 17, 2022
@stefanceriu stefanceriu added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Feb 17, 2022
@habi
Copy link
Author

habi commented Feb 17, 2022

This is a miss on our part and will add it asap 👍

Awesome, thanks!

That textual representation is there to make the share sheet show a pretty thumbnail but also to force apple maps to drop a pin when you open it.

No, I misunderstood.
I just thought the link should go to OSM, not Apple Maps.

@stefanceriu
Copy link
Member

I just thought the link should go to OSM, not Apple Maps.

Oh well we can easily add an option to open in OSM next to Apple and Google

@habi
Copy link
Author

habi commented Feb 17, 2022

add an option to open in OSM next to Apple and Google

That's a good idea, but was not the intention of this issue.
Thanks again for taking this on so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

2 participants