Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the accent colour in the legacy theme #5545

Closed
pixlwave opened this issue Feb 10, 2022 · 0 comments · Fixed by #5546
Closed

Update the accent colour in the legacy theme #5545

pixlwave opened this issue Feb 10, 2022 · 0 comments · Fixed by #5546
Labels
A-Theming T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@pixlwave
Copy link
Member

pixlwave commented Feb 10, 2022 •
edited
Loading

Your use case

The SwiftUI theme and ThemeV2 colours use 0x0DBD8B whereas anything using the legacy tint colour is getting a colour in the P3 colour space which looks more vibrant, but clashes with everything defined in sRGB from the Figma Compound.

Have you considered any alternatives?

We could switch everything to P3, but that would probably involve changes to assets etc too, and seeing as the sRGB version is what we use on Web (and presumably Android) it would make more sense to use that one.

Additional context

Discussed in Mobile Office Hours on 10th Feb.
@pixlwave pixlwave added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Feb 10, 2022
@pixlwave pixlwave mentioned this issue Feb 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Theming T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the tintColor in ThemeV1 to sRGB to match Compound and ThemeV2. element-hq/element-ios
1 participant
@pixlwave