Username and poll title sometimes overlay on top of each other

[kittykat]

Steps to reproduce

Sometimes poll layout is broken with the username covering part of the poll title. Not sure how to trigger it.

Outcome

Your phone model

iPhoneX

Operating system version

iOS 14.6

Application version

Test Flight

Homeserver

No response

Will you send logs?

No

[Johennes]

Similar cropping also occasionally happening at the bottom:

[frakic]

Still experiencing this on 1.8.20 (20220628212933)

Repro steps:

1. Web/Android user creates a poll in a room
2. iOS user tries to view it

[Johennes]

I looked into this issue some more. It's also reproducible by scrolling back to polls that didn't fit the initial screen.

I initially thought the height computation in SizableBaseRoomCell was wrong but even if I set a fixed and large enough size there, I'm still seeing layout issues in the polls cell.

Using the view hierarchy debugger, it looks like the hosting view has the right size but the content inside it is pushed down.

Long tapping the view to show the reactions overlay and then dismissing it fixes the layout (notably without changing the hosting view's position).

I've tried forcing a re-layout in numerous places but haven't been successful so far. The "best" I could get to was using the UIHostingView from SwiftUIX. The latter dynamically grows its parent when the hosted view's size changes. Oddly enough this made the cell revert to the clipped layout when scrolling back up which makes little sense to me.

Jul-03-2022.11-24-26.mp4

[Johennes]

@pixlwave spotted that the hosting view's size of 238 differs from the view's intrinsic content size of 285 (the constraint of which is grayed out / inactive). Understanding that mismatch could help getting closer to the root cause.

[Johennes]

In the case above, the hosting view's layout height of 238 is a result of the encapsulated layout height of 257 (applied through the table view / SizableBaseRoomCell height computation) minus the top / bottom margin of 19 applied on the hosting view's container.

On the one hand, this makes it look as if the height computation is wrong after all but, on the other, visually 238 appears to be enough to render the poll. 🤔

[Johennes]

It turns out that the hosting view adds safe area insets. 🤔

Some more info and a possible fix can be found in #6374.