Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: Location Sharing #5298

Closed
stefanceriu opened this issue Dec 13, 2021 · 0 comments
Closed

Meta: Location Sharing #5298

stefanceriu opened this issue Dec 13, 2021 · 0 comments
Assignees
@stefanceriu
Labels
A-Timeline Sponsored T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@stefanceriu
Copy link
Member

MSC
https://github.com/matrix-org/matrix-doc/blob/matthew/location/proposals/3488-location.md

Designs
https://www.figma.com/file/uthEK6xuo9hSQRdWvPAre5/Location-Sharing

Tickets
https://element-io.atlassian.net/browse/PSF-531 - Static Share - Send Device Location

  • I can share my current device location as a static location
  • So that I can inform people of where I am at the moment I send the message

Acceptance Criteria

  • I can not edit my location - this button should not be shown
  • Forwarding (and sharing) should be disabled
  • Reply and react should be enabled
  • I may be able to delete the location share

https://element-io.atlassian.net/browse/PSF-534 - Static Share - View Single Location

  • As a user in a room where someone has shared a static location
  • I can view that location on a map
  • So that I know where the user is

https://element-io.atlassian.net/browse/PSF-540 - Notification of Location Permissions

  • As a user trying to share location
  • I am notified if location sharing with Element is disabled at a device level
  • So that I can change my device settings

https://element-io.atlassian.net/browse/PSF-543 - Static Share - Delete Location

  • As a user who has shared my location
  • I can delete the message/event
  • So that users can no longer view that location

https://element-io.atlassian.net/browse/PSF-546 - Static Share - Text Fallback

  • As a user on a client where location sharing is not enabled
  • I receive a useful text-based message in place of a location share
  • So that I still have some useable information

https://element-io.atlassian.net/browse/PSF-551 - Disable Location Sharing

  • As a user
  • I can disable location sharing within settings
  • So that I cannot accidentally share my location
@stefanceriu stefanceriu self-assigned this Dec 13, 2021
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Dec 13, 2021
@stefanceriu
element-hq/element-ios/issues/5298 - Replaced "msgtype" strings with …
67953f3 
…new kMXMessageTypeKey.
stefanceriu added a commit that referenced this issue Dec 13, 2021
@stefanceriu
/issues/5298 - Replaced "msgtype" strings with new kMXMessageTypeKey.
372e97e
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Dec 13, 2021
@stefanceriu
element-hq/element-ios/issues/5298 - Added body and geo uri message c…
a4f095d 
…ontent keys, replaced plain string usages.
stefanceriu added a commit that referenced this issue Dec 13, 2021
@stefanceriu
/issues/5298 - Added body message content keys and replaced plain str…
228600d 
…ing usages.
@pixlwave pixlwave added A-Timeline Sponsored T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Dec 13, 2021
stefanceriu added a commit that referenced this issue Dec 16, 2021
@stefanceriu
/issues/5298 - Prevent the activity indicator modifier from reloading…
0e5501d 
… the whole view hierarchy.
stefanceriu added a commit that referenced this issue Dec 16, 2021
@stefanceriu
/issues/5298 - Implemented location sharing from the input toolbar ac…
a104292 
…tion menu.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Dec 16, 2021
@stefanceriu
element-hq/element-ios/issues/5298 - Added MXRoom location sharing me…
8b1ff11 
…thod.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Dec 16, 2021
@stefanceriu
element-hq/element-ios/issues/5298 - Replaced "msgtype" strings with …
9fe5017 
…new kMXMessageTypeKey.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Dec 16, 2021
@stefanceriu
element-hq/element-ios/issues/5298 - Added body and geo uri message c…
4e01e8d 
…ontent keys, replaced plain string usages.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Dec 16, 2021
@stefanceriu
element-hq/element-ios/issues/5298 - Added MXRoom location sharing me…
3bd6cb3 
…thod.
stefanceriu added a commit that referenced this issue Dec 16, 2021
@stefanceriu
/issues/5298 - Replaced "msgtype" strings with new kMXMessageTypeKey.
c4ddb82
stefanceriu added a commit that referenced this issue Dec 16, 2021
@stefanceriu
/issues/5298 - Added body message content keys and replaced plain str…
78ea8fb 
…ing usages.
stefanceriu added a commit that referenced this issue Dec 16, 2021
@stefanceriu
/issues/5298 - Prevent the activity indicator modifier from reloading…
50ac3ca 
… the whole view hierarchy.
stefanceriu added a commit that referenced this issue Dec 16, 2021
@stefanceriu
/issues/5298 - Implemented location sharing from the input toolbar ac…
034d779 
…tion menu.
stefanceriu added a commit that referenced this issue Dec 16, 2021
@stefanceriu
/issues/5298 - Implemented location sharing from the input toolbar ac…
aa9cbe0 
…tion menu.
stefanceriu added a commit that referenced this issue Dec 16, 2021
@stefanceriu
/issues/5298 - Attempting to set up cocoapods-keys.
8cd8df7
stefanceriu added a commit that referenced this issue Dec 17, 2021
@stefanceriu
/issues/5298 - Attempting to set up cocoapods-keys.
f04ce19
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Dec 17, 2021
@stefanceriu
element-hq/element-ios/issues/5298 - Replaced "msgtype" strings with …
61a2944 
…new kMXMessageTypeKey.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Dec 17, 2021
@stefanceriu
element-hq/element-ios/issues/5298 - Added body and geo uri message c…
3b9edf4 
…ontent keys, replaced plain string usages.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Dec 17, 2021
@stefanceriu
element-hq/element-ios/issues/5298 - Added MXRoom location sharing me…
103d7ef 
…thod.
stefanceriu added a commit that referenced this issue Dec 17, 2021
@stefanceriu
/issues/5298 - Replaced "msgtype" strings with new kMXMessageTypeKey.
c1a6a72
stefanceriu added a commit that referenced this issue Dec 17, 2021
@stefanceriu
/issues/5298 - Added body message content keys and replaced plain str…
f73c390 
…ing usages.
stefanceriu added a commit that referenced this issue Dec 17, 2021
@stefanceriu
/issues/5298 - Prevent the activity indicator modifier from reloading…
9e051fd 
… the whole view hierarchy.
stefanceriu added a commit that referenced this issue Dec 17, 2021
@stefanceriu
/issues/5298 - Implemented location sharing from the input toolbar ac…
8a5f2dc 
…tion menu.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jan 19, 2022
@stefanceriu
element-hq/element-ios/issues/5298 - Added changelog entry.
18d193e
stefanceriu added a commit that referenced this issue Jan 19, 2022
@stefanceriu
/issues/5298 - Added changelog entry.
34b4252
stefanceriu added a commit that referenced this issue Jan 19, 2022
@stefanceriu
/issues/5298 - Small tweaks following code review.
b45aff8
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jan 19, 2022
@stefanceriu
element-hq/element-ios/issues/5298 - Small tweaks following code review.
4673b72
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jan 19, 2022
@stefanceriu
element-hq/element-ios/issues/5298 - Correctly parse location data fr…
2788845 
…om `m.location` room messages.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jan 19, 2022
@stefanceriu
element-hq/element-ios/issues/5298 - Add support for location `m.asse…
cfdac87 
…t` types.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jan 19, 2022
@stefanceriu
element-hq/element-ios/issues/5298 - Using MXEventAssetTypeUser as de…
3f8db87 
…fault as per the MSC.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jan 19, 2022
@stefanceriu
element-hq/element-ios/issues/5298 - Added changelog entry.
a17786b
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jan 19, 2022
@stefanceriu
element-hq/element-ios/issues/5298 - Small tweaks following code review.
20424ad
stefanceriu added a commit that referenced this issue Jan 19, 2022
@stefanceriu
/issues/5298 - Add support for location m.asset types.
948e23d
stefanceriu added a commit that referenced this issue Jan 19, 2022
@stefanceriu
/issues/5298 - Added bottom padding on location markers so they point…
a0b6830 
… to the location instead of being centered on it.
stefanceriu added a commit that referenced this issue Jan 19, 2022
@stefanceriu
/issues/5298 - Removed cocoapods-keys and moved the MapTiler key to t…
821d606 
…he buildSettings.
stefanceriu added a commit that referenced this issue Jan 19, 2022
@stefanceriu
/issues/5298 - Added changelog entry.
18c11d6
stefanceriu added a commit that referenced this issue Jan 19, 2022
@stefanceriu
/issues/5298 - Small tweaks following code review.
13cfcef
stefanceriu added a commit that referenced this issue Jan 25, 2022
@stefanceriu
/issues/5298 - Reusing location sharing coordinator external sharing …
ceceb81 
…logic in the timeline.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jan 27, 2022
@stefanceriu
element-hq/element-ios/issues/5298 - Add .well-known parsing for tile…
bfdfa2d 
… server / map style configurations.
stefanceriu added a commit that referenced this issue Jan 27, 2022
@stefanceriu
/issues/5298 - Reusing location sharing coordinator external sharing …
2d13cc8 
…logic in the timeline.
stefanceriu added a commit that referenced this issue Jan 27, 2022
@stefanceriu
/issues/5298 - Add .well-known configuration support for tile server …
431a21c 
…and map styles.
stefanceriu added a commit that referenced this issue Jan 27, 2022
@stefanceriu
/issues/5298 - Add .well-known configuration support for tile server …
01363cf 
…and map styles.
stefanceriu added a commit that referenced this issue Feb 2, 2022
@stefanceriu
Closes /issues/5298 - Add changelog. Enable location sharing by default.
00f770d
stefanceriu added a commit that referenced this issue Feb 3, 2022
@stefanceriu
/issues/5298 - Tweaks following code review.
05dc8ff
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Feb 4, 2022
@stefanceriu
element-hq/element-ios/issues/5298 - Add .well-known parsing for tile…
be70db9 
… server / map style configurations.
stefanceriu added a commit that referenced this issue Feb 4, 2022
@stefanceriu
/issues/5298 - Reusing location sharing coordinator external sharing …
3b3bb39 
…logic in the timeline.
stefanceriu added a commit that referenced this issue Feb 4, 2022
@stefanceriu
/issues/5298 - Add .well-known configuration support for tile server …
684fbe7 
…and map styles.
stefanceriu added a commit that referenced this issue Feb 4, 2022
@stefanceriu
/issues/5298 - Tweaks following code review.
17127c6
stefanceriu added a commit that referenced this issue Feb 4, 2022
@stefanceriu
/issues/5298 - Reusing location sharing coordinator external sharing …
c92c46f 
…logic in the timeline.
stefanceriu added a commit that referenced this issue Feb 4, 2022
@stefanceriu
/issues/5298 - Add .well-known configuration support for tile server …
9ac722d 
…and map styles.
stefanceriu added a commit that referenced this issue Feb 4, 2022
@stefanceriu
/issues/5298 - Tweaks following code review.
cab5be2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanceriu stefanceriu

Labels
A-Timeline Sponsored T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanceriu @pixlwave