Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SP3.2: Long press on rooms in space room lists #5232

Closed
5 tasks done
Tracked by #16
nadonomy opened this issue Dec 1, 2021 · 2 comments
Closed
5 tasks done
Tracked by #16

SP3.2: Long press on rooms in space room lists #5232

nadonomy opened this issue Dec 1, 2021 · 2 comments
Assignees
Labels
A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@nadonomy
Copy link
Contributor

nadonomy commented Dec 1, 2021

Part of a larger project to implement Space creation & Space management on iOS.

Tasks

[Figma]

  • Add long press interaction on rooms in lists
    • Invite
    • Suggested
    • Room settings
    • Remove
@nadonomy nadonomy added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Spaces Spaces, groups, communities labels Dec 1, 2021
@nadonomy nadonomy changed the title SP3.1: Long press on rooms in space room lists SP3.2: Long press on rooms in space room lists Dec 1, 2021
@niquewoodhouse niquewoodhouse added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jan 14, 2022
@gileluard
Copy link
Contributor

We need to cover more use cases. Here are my thoughts:

  • The context menu is the same for spaces and rooms
  • Some actions can be disabled if the power level is not high enough to send state events to the parent of the selected room/space
  • Some actions can be disabled if the room/space has not been joined
  • Menu can change depending on the joined sate of the room/space

Menu items are the following ones:

  • invite: redirect the user to the invite screen
    • disabled if the user didn't join yet the room/space
  • suggest: (un)suggest the selected room/space (state item)
    • disabled it the power level of the user is not high enough to send state events to the parent of the selected room/space
  • settings: redirect the user to the settings of the selected room/space
    • item hidden if the user didn't join yet the room/space
  • join: allow to join the room/space
    • item hidden if the user already joined the room/space
  • remove: remove the room/space from its parent
    • disabled it the power level of the user is not high enough to send state events to the parent of the selected room/space

@nadonomy
Copy link
Contributor Author

Covering these sounds great. Happy to defer to @niquewoodhouse & @kittykat on thinking.

gileluard added a commit that referenced this issue Jan 17, 2022
- Added context menu for spaces and rooms in Explore rooms screen
gileluard added a commit that referenced this issue Feb 6, 2022
gileluard added a commit that referenced this issue Feb 6, 2022
gileluard added a commit that referenced this issue Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

3 participants