Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: Fix retain cycles #5058

Open
7 of 11 tasks
SBiOSoftWhare opened this issue Oct 29, 2021 · 0 comments
Open
7 of 11 tasks

Meta: Fix retain cycles #5058

SBiOSoftWhare opened this issue Oct 29, 2021 · 0 comments
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@SBiOSoftWhare
Copy link
Contributor

SBiOSoftWhare commented Oct 29, 2021 •
edited by Johennes
Loading

Classes where retain cycles are observed:

  • SettingsViewController
  • ContactsTableViewController
  • ContactDetailsViewController
  • EnterNewRoomDetailsViewController
  • GroupsViewController
  • SegmentedViewController
  • MXKGroupListViewController
  • StartChatViewController
  • FindYourContactsFooterView
  • RoomInfoListViewController
  • UserSuggestionCoordinator

Check for:

  • MXKBarButtonItem with completion that retains self
  • .presentationController?.delegate = self that seems to create retain cycles
  • NSNotificationCenter addObserverForName:object:queue:usingBlock: that retain self
  • blocks that retain self while the block is retain by self
  • delegate property with strong reference instead of weak
@SBiOSoftWhare SBiOSoftWhare added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 29, 2021
This was referenced Oct 29, 2021
Merged
Merged
@pixlwave pixlwave added T-Task Refactoring, enabling or disabling functionality, other engineering tasks and removed T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Nov 22, 2021
Johennes added a commit to Johennes/element-ios that referenced this issue Mar 18, 2022
@Johennes
Fix retain cycle in UserSuggestionViewModel
40650cb 
Steps to reproduce:

- Launch app
- Enter and leave a bunch of rooms
- Fire up the memory graph debugger
- Filter for `UserSuggestionViewModel`

Relates to: element-hq#5058
Signed-off-by: Johannes Marbach <[email protected]>
@Johennes Johennes mentioned this issue Mar 18, 2022
Merged
8 tasks
stefanceriu pushed a commit that referenced this issue Mar 21, 2022
@Johennes @stefanceriu
Fix retain cycle in UserSuggestionViewModel
c734d7c 
Steps to reproduce:

- Launch app
- Enter and leave a bunch of rooms
- Fire up the memory graph debugger
- Filter for `UserSuggestionViewModel`

Relates to: #5058
Signed-off-by: Johannes Marbach <[email protected]>
Johennes added a commit that referenced this issue Mar 27, 2022
@Johennes
Fix retain cycle in MXKRoomDataSource
945f810 
Relates to: #5058
Signed-off-by: Johannes Marbach <[email protected]>
@Johennes Johennes mentioned this issue Mar 27, 2022
Merged
8 tasks
Johennes added a commit to matrix-org/matrix-ios-sdk that referenced this issue Mar 27, 2022
@Johennes
Fix retain cycles in MXEventListener & MXRoomSummary
a744830 
Relates to: element-hq/element-ios#5058
Signed-off-by: Johannes Marbach <[email protected]>
@Johennes Johennes mentioned this issue Mar 27, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SBiOSoftWhare @pixlwave