Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share extension selection shape should be circular and use the tint colour. #5041

Closed
pixlwave opened this issue Oct 25, 2021 · 0 comments · Fixed by #5043
Closed

Share extension selection shape should be circular and use the tint colour. #5041

pixlwave opened this issue Oct 25, 2021 · 0 comments · Fixed by #5043
Assignees
@stefanceriu
Labels
A-ShareExtension O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@pixlwave
Copy link
Member

Steps to reproduce

  1. Share a photo from the photos app (or forward a message from inside of Element).
  2. Select one or more rooms to send to.

What happened?

What did you expect?

That the highlight would match the original circle shape (and be green).

What happened?

The highlight is a rounded rect and is blue.
ima_b8a7697

Your phone model

iPhone 12 / iPhone SE

Operating system version

iOS 15.0.1

Application version

Element 1.6.6 (TestFlight)

Homeserver

No response

Have you submitted a rageshake?

No
@pixlwave pixlwave added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-ShareExtension O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users labels Oct 25, 2021
@stefanceriu stefanceriu self-assigned this Oct 25, 2021
stefanceriu added a commit that referenced this issue Oct 25, 2021
@stefanceriu
/issues/5041 - Fixed share extension and message forwarding room list…
8674c5f 
… accessory view icon.
@pixlwave pixlwave linked a pull request Oct 25, 2021 that will close this issue
vector-im/element-ios/issues/5041 - Fixed share extension and message… #5043
Merged
stefanceriu added a commit that referenced this issue Oct 25, 2021
@stefanceriu
/issues/5041 - Fixed share extension and message forwarding room list…
fe98559 
… accessory view icon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanceriu stefanceriu

Labels
A-ShareExtension O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vector-im/element-ios/issues/5041 - Fixed share extension and message… element-hq/element-ios
2 participants
@stefanceriu @pixlwave