Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message forwarding #5014

Merged
merged 5 commits into from
Oct 19, 2021
Merged

Message forwarding #5014

merged 5 commits into from
Oct 19, 2021

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Oct 15, 2021 •
edited
Loading

Implemented in app message forwarding. We wanted to reuse the already existing share extension code and in order to do so I made the following changes:

  • moved away from ShareExtensionManager singleton
  • moved business logic away from view controllers
  • extracted NSExtensionContext dependant code from the ShareManager
  • introduced a ShareItemProviderProtocol responsible for providing content from either the main application or the shareExtensionContext
  • implemented multi room sending and UI

Currently missing:

  • recently contacted contacts section
  • "forwarded from" subtitle in the destination

How it looks like:
Forward button Forwarding from within the application Share extension

@stefanceriu stefanceriu marked this pull request as ready for review October 18, 2021 13:52
@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/z4ea5d

gaelledel
gaelledel reviewed Oct 18, 2021
View reviewed changes
Copy link

@gaelledel gaelledel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a message is forwarded, we should show a string that says "Forwarded message" in the UI
Screenshot 2021-10-18 at 15 34 02

@stefanceriu
Copy link
Member Author

We currently don't have any support for marking messages as forwarded but we do have 2 competing MSCs for it. The client implementation will need to come at a later date.
MSC2723: Forwarded message metadata
MSC2730: Verifiable forwarded events

@stefanceriu stefanceriu merged commit 6f7a914 into develop Oct 19, 2021
@stefanceriu stefanceriu deleted the stefan/messageForwarding branch October 19, 2021 13:17
stefanceriu added a commit that referenced this pull request Nov 9, 2021
@stefanceriu
/pull/5014 - Forward original message content and remove the need to …
1861ec8 
…re-upload media.
stefanceriu added a commit that referenced this pull request Nov 9, 2021
@stefanceriu
/pull/5014 - Forward original message content and remove the need to …
c961a71 
…re-upload media.
This was referenced Dec 3, 2021
Closed
Closed
phloux pushed a commit to tchapgouv/tchap-ios that referenced this pull request Jan 18, 2022
@stefanceriu
element-hq/element-ios/pull/5014 - Forward original message content a…
1bfa1bc 
…nd remove the need to re-upload media.
@pixlwave pixlwave mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaelledel gaelledel gaelledel approved these changes

@SBiOSoftWhare SBiOSoftWhare SBiOSoftWhare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanceriu @SBiOSoftWhare @gaelledel