Share extension asks you to compress videos/photos even if setting is disabled

[aaronraimist]

Steps to reproduce

1. Check that "Confirm size when sending" is disabled in Element
2. Open the Photos app
3. Share a video
4. Tap Element
5. Tap a room

What happened?

What did you expect?

You wouldn't be asked to compress the file

What happened?

You are asked to compress the file

Your phone model

No response

Operating system version

No response

Application version

1.5.3

Homeserver

No response

Have you submitted a rageshake?

No

[pixlwave]

Thanks for the report.

The explanation on this one is that sending images as Actual Size can hit the memory limit in the Share Extension, likewise if the room is encrypted and a video has a large file size. This hasn't been made clear though, will look into it.

[niquewoodhouse]

If user has disabled size selector:

• Skip step if file is small enough to be super confident it wont fail sending
• If file size is too large, we need the selector but should use the copy to explain why.

Copy ideas:

• Confirm size to send. This file is too large to send as it is.
• Confirm size to send. File might be too large to send, so we need to ask.

[niquewoodhouse]

I've taken a quick look at some 360p footage to see how bad the experience is on my phone. It's absolutely not great but it does feel better than being informed I can't do something. https://www.youtube.com/watch?v=_hUGhoB2FnM

[aaronraimist]

Btw this is a very minor issue. Definitely prioritize more important things.

#4815 (comment) seems like a fine solution or even just a small copy tweak to the sentence that appears below the preference would be fine.

[pixlwave]

@aaronraimist Whilst it is minor from the perspective sending images (which has a simple fix), it is more important for videos in encrypted rooms as right now the extension is terminated pretty easily by using too much memory and so we're trying to find the best way to fix that too.

[pixlwave]

Figma link for videos: https://www.figma.com/file/mfRBzaGNZxFckB4lrNnip0/%5BiOS%5D-resolution-when-sending-image%2Fvideo?node-id=205%3A7939

[pixlwave]

Fixed in #5059.