Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voice Messages - Hold and send #4090

Closed
3 tasks
gileluard opened this issue Mar 3, 2021 · 1 comment · Fixed by #4433
Closed
3 tasks

Voice Messages - Hold and send #4090

gileluard opened this issue Mar 3, 2021 · 1 comment · Fixed by #4433
Assignees
@stefanceriu
Labels
Sponsored

Comments

@gileluard
Copy link
Contributor

gileluard commented Mar 3, 2021 •
edited by giomfo
Loading

  • Add a voice message button to the composer
  • OnLongPress on the MIC, it gets activated and the recording start. If the user releases the finger, the message gets sent
  • Voice messages last up to 2min. On the last 10s a toast notification is displayed warning users of time left. In this mode, if the user goes over the limit, the message gets sent.
@giomfo
Copy link
Member

giomfo commented Mar 4, 2021

Note: MSC2516 is under review to add a new message type for voice messages. We will have to use org.matrix.msc2516.voice as the msgtype for now, but once it's in the spec properly then we can switch to m.voice.
What will probably end up happening is in code there will be a if (msgtype === "org.matrix.msc2516.voice" || msgtype === "m.voice") statement for several releases, once m.voice is allowed.

@stefanceriu stefanceriu self-assigned this Jun 3, 2021
stefanceriu added a commit that referenced this issue Jun 3, 2021
@stefanceriu
#4090 - New voice recording toolbar ui and swipe to cancel interaction.
3dbbfe7
stefanceriu added a commit that referenced this issue Jun 3, 2021
@stefanceriu
#4090 - Corrected dark theme appearance.
b126854
stefanceriu added a commit that referenced this issue Jun 3, 2021
@stefanceriu
#4090 - New voice recording toolbar ui and swipe to cancel interaction.
2b50696
stefanceriu added a commit that referenced this issue Jun 3, 2021
@stefanceriu
#4090 - Corrected dark theme appearance.
9ed0622
stefanceriu added a commit that referenced this issue Jun 4, 2021
@stefanceriu
#4090 - Corrected dark theme appearance.
ff537e8
stefanceriu added a commit that referenced this issue Jun 7, 2021
@stefanceriu
#4090 - Add voice message controller, audio recorder and toolbar view…
05a8144 
… links.
stefanceriu added a commit that referenced this issue Jun 7, 2021
@stefanceriu
#4090 - Add voice message controller, audio recorder and toolbar view…
f0c9138 
… links. Working audio file sending and cancellation.
stefanceriu added a commit that referenced this issue Jun 8, 2021
@stefanceriu
#4090 - Added recording duration label and permissions checking.
604ee7e
stefanceriu added a commit that referenced this issue Jun 8, 2021
@stefanceriu
#4090 - New voice recording toolbar ui and swipe to cancel interaction.
4d86d35
stefanceriu added a commit that referenced this issue Jun 8, 2021
@stefanceriu
#4090 - Corrected dark theme appearance.
5e6379a
stefanceriu added a commit that referenced this issue Jun 8, 2021
@stefanceriu
#4090 - Corrected dark theme appearance.
e8667df
stefanceriu added a commit that referenced this issue Jun 8, 2021
@stefanceriu
#4090 - Add voice message controller, audio recorder and toolbar view…
0be58d1 
… links. Working audio file sending and cancellation.
stefanceriu added a commit that referenced this issue Jun 8, 2021
@stefanceriu
#4090 - Added recording duration label and permissions checking.
a581a22
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jun 8, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Added additional message types s…
27720aa 
…upport and sendVoiceMessage method.
stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue Jun 8, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Added sendAudioFile and sendVoic…
63b9eb9 
…eMessage methods on the MXKRoomDataSource.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jun 9, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Moved the voice message type to …
5fea5d4 
…MXEvent.
stefanceriu added a commit that referenced this issue Jun 9, 2021
@stefanceriu
#4090 - New voice recording toolbar ui and swipe to cancel interaction.
cab2e68
stefanceriu added a commit that referenced this issue Jun 9, 2021
@stefanceriu
#4090 - Corrected dark theme appearance.
a2b51e0
stefanceriu added a commit that referenced this issue Jun 9, 2021
@stefanceriu
#4090 - Corrected dark theme appearance.
d2f22c2
stefanceriu added a commit that referenced this issue Jun 9, 2021
@stefanceriu
#4090 - Add voice message controller, audio recorder and toolbar view…
d882297 
… links. Working audio file sending and cancellation.
stefanceriu added a commit that referenced this issue Jun 9, 2021
@stefanceriu
#4090 - Added recording duration label and permissions checking.
11bbe3a
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jun 9, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Made sendVoiceMessage `mimeTyp…
f85f0f3 
…e` optional, defaulting to `audio/ogg`.
stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue Jun 9, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Marked the mimeType as optional …
a94c434 
…on `sendVoiceMessage`.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jun 9, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Check against nil/empty addition…
674c058 
…alTypes dictionary on seding files.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jun 9, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Added the .voiceMessage type to …
6bf439e 
…MXEvent.swift as well.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jun 9, 2021
@stefanceriu
Send voice messages (#1119)
6cf7a91 
element-hq/element-ios/issues/4090 - Added additional message types support and sendVoiceMessage method.
stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue Jun 9, 2021
@stefanceriu
Send audio files and voice messages (#829)
2dfde1a 
element-hq/element-ios/issues/4090 - Added sendAudioFile and sendVoiceMessage methods on the MXKRoomDataSource.
stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue Jun 23, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Added the VoiceMessage attacheme…
e855a71 
…nt type.
stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue Jun 23, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Added voice messages microphone …
48413da 
…permissions localizable string.
stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue Jun 23, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Updated Changes.rst.
dcee4a2
gileluard added a commit that referenced this issue Jun 29, 2021
@gileluard
#4090 - Use a dedicated dispatch queue for process
e8a3084
gileluard added a commit that referenced this issue Jun 29, 2021
@gileluard
#4090 - Fixed UI regression if `BuildSettings.voiceMessagesEnabled = …
78cb2b8 
…false`
gileluard added a commit that referenced this issue Jun 29, 2021
@gileluard
#4090 - Hide voice message button when on action mode
397f88c
gileluard added a commit that referenced this issue Jun 29, 2021
@gileluard
#4090 - bug fixing and removed work queue
c421af0
gileluard added a commit that referenced this issue Jun 29, 2021
@gileluard
#4090 - fixed small theme issues
760f03d
gileluard added a commit that referenced this issue Jul 2, 2021
@gileluard
#4090 - Improved performances
05c02c3
@gileluard gileluard mentioned this issue Jul 6, 2021
Merged
gileluard added a commit that referenced this issue Jul 6, 2021
@gileluard
#4090 - Update after review
e492d2b
gileluard added a commit that referenced this issue Jul 9, 2021
@gileluard
#4090 - Update after review
65415c4
stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue Jul 13, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Add custom reply text to voice m…
9ca446d 
…essages, add duration and samples to sendVoiceMessage.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jul 13, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Add custom reply text to voice m…
3e8f798 
…essages, add duration and samples to sendVoiceMessage.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jul 13, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Fixed documentation typo.
0cf112c
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jul 13, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Add custom reply text to voice m…
fa5bd6d 
…e… (#1156)

* element-hq/element-ios/issues/4090 - Add custom reply text to voice messages, add duration and samples to sendVoiceMessage.
stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue Jul 13, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Add custom reply text to voice m…
15904d7 
…essages, add duration and samples to sendVoiceMessage.
stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue Jul 16, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Switched the sendVoiceMessage me…
49a982d 
…thod duration parameter to an integer.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jul 16, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Switched the sendVoiceMessage me…
2336a17 
…thod duration parameter to an integer.
stefanceriu added a commit that referenced this issue Jul 16, 2021
@stefanceriu
#4090 - Switched the sendVoiceMessage method duration parameter to an…
511569a 
… integer.
stefanceriu added a commit that referenced this issue Jul 16, 2021
@stefanceriu
#4090 - Changed FFMpeg-Kit to the LTS version and moved the project b…
488338f 
…ack to deployment target 11.0.
stefanceriu added a commit that referenced this issue Jul 16, 2021
@stefanceriu
#4090 - Fixed the AttachmentCacheManager's serial nature.
79bb35d
stefanceriu added a commit that referenced this issue Jul 16, 2021
@stefanceriu
#4090 - Fixed the AttachmentCacheManager's serial nature.
ec33ec8
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jul 16, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Switched the sendVoiceMessage me…
a2183ba 
…thod duration parameter to an integer.
stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue Jul 16, 2021
@stefanceriu
element-hq/element-ios/issues/4090 - Switched the sendVoiceMessage me…
6f6dbae 
…thod duration parameter to an integer.
stefanceriu added a commit that referenced this issue Jul 16, 2021
@stefanceriu
#4090 - Added voice messages switch to the labs section in settings.
089c688
stefanceriu added a commit that referenced this issue Jul 19, 2021
@stefanceriu
#4090 - Various tweaks and fixes following code review. Switched back…
c644895 
… to DateFormatters for formatting durations, sanitising audio player durations and current times.
stefanceriu added a commit that referenced this issue Jul 19, 2021
@stefanceriu
#4090 - Various tweaks and fixes following code review. Switched back…
0ead60f 
… to DateFormatters for formatting durations, sanitising audio player durations and current times.
stefanceriu added a commit that referenced this issue Jul 19, 2021
@stefanceriu
#4090 - Activating the shared AVAudioSession before recording or play…
39084b0 
…back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanceriu stefanceriu

Labels
Sponsored
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Voice messages element-hq/element-ios
3 participants
@stefanceriu @giomfo @gileluard