Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run a quick test of the RC on a Windows machine #1406

Open
victhorbi opened this issue Oct 10, 2024 · 2 comments
Open

Run a quick test of the RC on a Windows machine #1406

victhorbi opened this issue Oct 10, 2024 · 2 comments

Comments

@victhorbi
Copy link
Collaborator

No description provided.

@leszek-vechain
Copy link
Collaborator

Description

I was able to get my hands on windows laptop (8GB RAM) with following configuration:

  • Windows 11 Version 23H2 (2024-10)
  • git 2.47.0.2
  • node 20.18 LTS
  • Webstorm 2024.2.4 Community Edition

Steps

  1. clone repo - no issues
  2. installed yarn - no issues
  3. yarn install - no issues
  4. yarn build - a few problems arrived
  5. yarn test - another bunch of problems

Problems - yarn build

Rm -rf usage
It seems we use a lot of rm -rf commands to remove certain ./dist folders, but Windows does not have any equivalent for that.

Solution
Install rimraf package via yarn and update the package.json files with "rimraf ./dist" instead of "rm -rf dist"

Error: Delete 'cr' prettier/prettier
This one was connected to sdk-nextjs-integration app, it seems that on windows files in that folder have end line characters added, and eslint does not like it.

Solution
Set endOfLine to auto in .eslintrc.json in app folder:

{
    'prettier/prettier': [
        "error", {
            "endOfLine": "auto"
        }
    ]
}

it skips the check - not ideal but it works.

Docs not building
Docs are using find command to filter and delete files during build, but windows does not have any equivalent for it.

Solution
None, just skipped build for docs.

**Problems - yarn test:solo"

Docker
To run this we need docker for windows. Installed version 4.34.3, but it did not want to start at all. Long story short, there is an ongoing issue with WSL (Windows Subsystem for Linux).

Solution
I did update to version 2.3.24.0, but this solution not always works for everyone.

Docker compose -f
For some reason docker did not like -f param in sdk-aws-kms-adapter start thor solo command. It did throw this error:

sdk-aws-kms-adapter:test: unknown shorthand flag: 'f' in -f
sdk-aws-kms-adapter:test: See 'docker --help'

Solution
None for now

Test passed

  • sdk-errors: all
  • sdk-logging: all
  • sdk-aws-kms-adapter: none
  • sdk-next-js-integration: all
  • sdk-rpc-proxy: 5/6
  • sdk-integration-node: all
  • sdk-cloudflare-integration: worker died
  • sdk-core: all
  • sdk-ethers-adapter: all
  • sdk-hardhat-plugin: 5/6
  • rest - not run

The reason why they fail is too low specced laptop as docker + windows eats tons of RAM. Most failures were connected to timeouts and some docker issues.

@victhorbi
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants