Skip to content

Commit

Permalink
fix(ecs): removed omitEmptyArray for placementConstraints (aws#27555) (
Browse files Browse the repository at this point in the history
…aws#30382)

### Issue 

fixes aws#27555 
Closes Half Fix [i.e, Allows user to give Empty Placement Constraints ]  aws#27555 

This PR does not address supporting empty placement strategies because of the following reason : [27555 : comment](aws#27572 (comment))

This was raised with the guidance from - [pr / 28431 : Comment ](aws#28431 (comment))

### Reason for this change

Users unable to give empty placementConstraints

### Description of how you validated changes

- Added a UnitCase to cover with empty `[]` placementConstraints
- Integration Tests
```
$ yarn integ test/aws-ecs/test/ec2/integ.placement-constraint-default-empty.js --update-on-failed
```
After integ tests were completed, `npm test` to verify the snapshot.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
stm29 authored and Dahlberg Victor committed Jun 10, 2024
1 parent 255768c commit a440d02
Show file tree
Hide file tree
Showing 11 changed files with 3,209 additions and 4 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit a440d02

Please sign in to comment.