Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace x/slices with standard slices pkg #2193

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Replace x/slices with standard slices pkg #2193

merged 5 commits into from
Sep 20, 2023

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Sep 19, 2023 •
edited by vankichi
Loading

Description:

Since go v1.21, slices pkg becomes standard with multiple new functions. So this PR replaces old x/slices pkg with the new slices pkg.

Related Issue:

Versions:

  • Go Version: 1.21.1
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.2
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 19, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e1bae85
Status: ✅  Deploy successful!
Preview URL: https://7a481462.vald.pages.dev
Branch Preview URL: https://feature-internal-use-standar.vald.pages.dev

View logs

@ykadowak ykadowak force-pushed the feature/internal/use-standard-slices branch from b0af0b5 to 68db1ab Compare September 19, 2023 03:47
@ykadowak ykadowak requested review from a team, kevindiu and vankichi and removed request for a team September 19, 2023 03:59
@github-actions github-actions bot added size/XL and removed size/L labels Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Patch coverage is 21.05% of modified lines.

Files Changed Coverage
hack/tools/metrics/main.go 0.00%
internal/file/file.go 0.00%
internal/info/info.go ø
internal/net/grpc/pool/pool.go ø
pkg/agent/core/ngt/service/ngt.go ø
pkg/discoverer/k8s/service/discover.go 0.00%
pkg/gateway/filter/usecase/vald.go ø
pkg/gateway/lb/handler/grpc/aggregation.go 0.00%
pkg/gateway/lb/handler/grpc/handler.go ø
internal/net/grpc/stream.go 50.00%
... and 1 more

📢 Thoughts on this report? Let us know!.

kevindiu
kevindiu previously approved these changes Sep 19, 2023
View reviewed changes
@github-actions
Copy link
Contributor

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/feature%2Finternal%2Fuse-standard-slices/985713f600b858dbe30cb671aadc0c9028a58f37

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

kpango
kpango reviewed Sep 20, 2023
View reviewed changes
pkg/gateway/lb/handler/grpc/aggregation.go Outdated Show resolved Hide resolved
internal/net/grpc/stream.go Outdated Show resolved Hide resolved
@ykadowak ykadowak requested review from kevindiu and kpango September 20, 2023 05:42
@ykadowak ykadowak merged commit 594b23b into main Sep 20, 2023
66 of 68 checks passed
@ykadowak ykadowak deleted the feature/internal/use-standard-slices branch September 20, 2023 06:55
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Replace x/slices with standard slices pkg (#2193)"
12e5de6 
This reverts commit 594b23b.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Replace x/slices with standard slices pkg (#2193)"
0b64e27 
This reverts commit 594b23b.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Replace x/slices with standard slices pkg (#2193)"
6578999 
This reverts commit 594b23b.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Replace x/slices with standard slices pkg (#2193)"
28b25f3 
This reverts commit 594b23b.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Replace x/slices with standard slices pkg (#2193)"
4f8f393 
This reverts commit 594b23b.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Replace x/slices with standard slices pkg (#2193)"
4f69778 
This reverts commit 594b23b.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Replace x/slices with standard slices pkg (#2193)"
85be79d 
This reverts commit 594b23b.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Replace x/slices with standard slices pkg (#2193)"
bf2922e 
This reverts commit 594b23b.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Replace x/slices with standard slices pkg (#2193)"
fd02513 
This reverts commit 594b23b.
@vankichi vankichi mentioned this pull request Dec 4, 2023
Merged
kmrmt pushed a commit that referenced this pull request Dec 12, 2023
@ykadowak @kmrmt
Replace x/slices with standard slices pkg (#2193)
808a8dd 
* Replace x/slices with slices pkg

* update go/exp

* Define private removeDuplicates

* remove internal/slices pkg

* fix generics type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpango kpango kpango approved these changes

@kevindiu kevindiu kevindiu approved these changes

@vankichi vankichi Awaiting requested review from vankichi vankichi was automatically assigned from vdaas/maintainer

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-max-dim actions/e2e-profiling actions/fossa area/agent/core area/discoverer area/gateway/filter area/gateway/lb area/internal priority/medium size/XL team/set SET team type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykadowak @vdaas-ci @kevindiu @kpango