From f66fc226ffd78dc0cb5f79e4d38b59adf573467a Mon Sep 17 00:00:00 2001 From: vankichi Date: Thu, 8 Sep 2022 17:51:39 +0900 Subject: [PATCH] :recycle: apply feedback Signed-off-by: vankichi --- internal/k8s/benchmark/job/job.go | 1 + internal/k8s/benchmark/operator/operator.go | 1 + internal/k8s/benchmark/operator/types.go | 6 +++--- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/internal/k8s/benchmark/job/job.go b/internal/k8s/benchmark/job/job.go index 81550c2c91..6cdfaf6b2e 100644 --- a/internal/k8s/benchmark/job/job.go +++ b/internal/k8s/benchmark/job/job.go @@ -42,6 +42,7 @@ type reconciler struct { func New(opts ...Option) BenchmarkJobWatcher { r := new(reconciler) for _, opt := range append(defaultOpts, opts...) { + // TODO: impl error handling after implement functional option opt(r) } return r diff --git a/internal/k8s/benchmark/operator/operator.go b/internal/k8s/benchmark/operator/operator.go index ded56e2a44..9a2cba099f 100644 --- a/internal/k8s/benchmark/operator/operator.go +++ b/internal/k8s/benchmark/operator/operator.go @@ -42,6 +42,7 @@ type reconciler struct { func New(opts ...Option) BenchmarkOperatorWatcher { r := new(reconciler) for _, opt := range append(defaultOpts, opts...) { + // TODO: impl error handling after implement functional option opt(r) } return r diff --git a/internal/k8s/benchmark/operator/types.go b/internal/k8s/benchmark/operator/types.go index 1a7a727ffd..378b8facec 100644 --- a/internal/k8s/benchmark/operator/types.go +++ b/internal/k8s/benchmark/operator/types.go @@ -31,9 +31,9 @@ type BenchmarkOperatorSpec struct { type BenchmarkOperatorStatus string const ( - BenchmarkOperatorNotReady = BenchmarkOperatorStatus("NotReady") - BenchmarkOperatorAvailable = BenchmarkOperatorStatus("Available") - BenchmarkOperatorHealthy = BenchmarkOperatorStatus("Healthy") + BenchmarkOperatorNotReady BenchmarkOperatorStatus = "NotReady" + BenchmarkOperatorAvailable BenchmarkOperatorStatus = "Available" + BenchmarkOperatorHealthy BenchmarkOperatorStatus = "Healthy" ) type BenchmarkOperator struct {