From 895ae0b46688ed57124774882e759fe5bcc3cf28 Mon Sep 17 00:00:00 2001 From: Rintaro Okamura Date: Mon, 18 May 2020 12:56:03 +0900 Subject: [PATCH 1/3] =?UTF-8?q?=E2=9C=A8=20Add=20topology=20spread=20const?= =?UTF-8?q?raints=20(#383)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * :wheel_of_dharma: Add topologySpreadConstraints Signed-off-by: Rintaro Okamura * :pencil: write about pods topology spread constraints Signed-off-by: Rintaro Okamura * :pencil: Revise pod scheduling section Signed-off-by: Rintaro Okamura * :robot: Update license headers and formatting go codes Signed-off-by: vdaas-ci Co-authored-by: vdaas-ci --- charts/vald/templates/agent/daemonset.yaml | 4 ++++ charts/vald/templates/agent/deployment.yaml | 2 ++ charts/vald/templates/agent/statefulset.yaml | 2 ++ .../vald/templates/discoverer/daemonset.yaml | 4 ++++ .../vald/templates/discoverer/deployment.yaml | 2 ++ .../templates/gateway/vald/daemonset.yaml | 4 ++++ .../templates/gateway/vald/deployment.yaml | 2 ++ .../templates/manager/backup/daemonset.yaml | 4 ++++ .../templates/manager/backup/deployment.yaml | 2 ++ .../manager/compressor/daemonset.yaml | 4 ++++ .../manager/compressor/deployment.yaml | 2 ++ .../templates/manager/index/daemonset.yaml | 4 ++++ .../templates/manager/index/deployment.yaml | 2 ++ charts/vald/templates/meta/daemonset.yaml | 4 ++++ charts/vald/templates/meta/deployment.yaml | 2 ++ charts/vald/values.yaml | 14 ++++++++++++ docs/guides/configurations.md | 22 +++++++++++++++++-- go.mod | 2 +- go.sum | 2 ++ 19 files changed, 81 insertions(+), 3 deletions(-) diff --git a/charts/vald/templates/agent/daemonset.yaml b/charts/vald/templates/agent/daemonset.yaml index 2d86ea89401..e4cdc20843b 100644 --- a/charts/vald/templates/agent/daemonset.yaml +++ b/charts/vald/templates/agent/daemonset.yaml @@ -50,6 +50,10 @@ spec: {{- $initContainers := dict "initContainers" .Values.agent.initContainers "Values" .Values "namespace" .Release.Namespace -}} {{- include "vald.initContainers" $initContainers | trim | nindent 8 }} {{- end }} + affinity: + {{- include "vald.affinity" .Values.agent.affinity | nindent 8 }} + topologySpreadConstraints: + {{- toYaml .Values.agent.topologySpreadConstraints | nindent 8 }} containers: - name: {{ .Values.agent.name }} image: "{{ .Values.agent.image.repository }}:{{ default .Values.defaults.image.tag .Values.agent.image.tag }}" diff --git a/charts/vald/templates/agent/deployment.yaml b/charts/vald/templates/agent/deployment.yaml index a9e028f5325..c2b8bc792d4 100644 --- a/charts/vald/templates/agent/deployment.yaml +++ b/charts/vald/templates/agent/deployment.yaml @@ -57,6 +57,8 @@ spec: {{- end }} affinity: {{- include "vald.affinity" .Values.agent.affinity | nindent 8 }} + topologySpreadConstraints: + {{- toYaml .Values.agent.topologySpreadConstraints | nindent 8 }} containers: - name: {{ .Values.agent.name }} image: "{{ .Values.agent.image.repository }}:{{ default .Values.defaults.image.tag .Values.agent.image.tag }}" diff --git a/charts/vald/templates/agent/statefulset.yaml b/charts/vald/templates/agent/statefulset.yaml index 72ede9783b6..27ef9df59fa 100644 --- a/charts/vald/templates/agent/statefulset.yaml +++ b/charts/vald/templates/agent/statefulset.yaml @@ -57,6 +57,8 @@ spec: {{- end }} affinity: {{- include "vald.affinity" .Values.agent.affinity | nindent 8 }} + topologySpreadConstraints: + {{- toYaml .Values.agent.topologySpreadConstraints | nindent 8 }} containers: - name: {{ .Values.agent.name }} image: "{{ .Values.agent.image.repository }}:{{ default .Values.defaults.image.tag .Values.agent.image.tag }}" diff --git a/charts/vald/templates/discoverer/daemonset.yaml b/charts/vald/templates/discoverer/daemonset.yaml index c0d2e5d44dc..cbad3f7fd4d 100644 --- a/charts/vald/templates/discoverer/daemonset.yaml +++ b/charts/vald/templates/discoverer/daemonset.yaml @@ -49,6 +49,10 @@ spec: {{- $initContainers := dict "initContainers" .Values.discoverer.initContainers "Values" .Values "namespace" .Release.Namespace -}} {{- include "vald.initContainers" $initContainers | trim | nindent 8 }} {{- end }} + affinity: + {{- include "vald.affinity" .Values.discoverer.affinity | nindent 8 }} + topologySpreadConstraints: + {{- toYaml .Values.discoverer.topologySpreadConstraints | nindent 8 }} containers: - name: {{ .Values.discoverer.name }} image: "{{ .Values.discoverer.image.repository }}:{{ default .Values.defaults.image.tag .Values.discoverer.image.tag }}" diff --git a/charts/vald/templates/discoverer/deployment.yaml b/charts/vald/templates/discoverer/deployment.yaml index 4d1444061dd..97b566c9dca 100644 --- a/charts/vald/templates/discoverer/deployment.yaml +++ b/charts/vald/templates/discoverer/deployment.yaml @@ -56,6 +56,8 @@ spec: {{- end }} affinity: {{- include "vald.affinity" .Values.discoverer.affinity | nindent 8 }} + topologySpreadConstraints: + {{- toYaml .Values.discoverer.topologySpreadConstraints | nindent 8 }} containers: - name: {{ .Values.discoverer.name }} image: "{{ .Values.discoverer.image.repository }}:{{ default .Values.defaults.image.tag .Values.discoverer.image.tag }}" diff --git a/charts/vald/templates/gateway/vald/daemonset.yaml b/charts/vald/templates/gateway/vald/daemonset.yaml index 93039a16230..766d891c32b 100644 --- a/charts/vald/templates/gateway/vald/daemonset.yaml +++ b/charts/vald/templates/gateway/vald/daemonset.yaml @@ -49,6 +49,10 @@ spec: {{- $initContainers := dict "initContainers" .Values.gateway.initContainers "Values" .Values "namespace" .Release.Namespace -}} {{- include "vald.initContainers" $initContainers | trim | nindent 8 }} {{- end }} + affinity: + {{- include "vald.affinity" .Values.gateway.affinity | nindent 8 }} + topologySpreadConstraints: + {{- toYaml .Values.gateway.topologySpreadConstraints | nindent 8 }} containers: - name: {{ .Values.gateway.name }} image: "{{ .Values.gateway.image.repository }}:{{ default .Values.defaults.image.tag .Values.gateway.image.tag }}" diff --git a/charts/vald/templates/gateway/vald/deployment.yaml b/charts/vald/templates/gateway/vald/deployment.yaml index f355211d71e..e549f2171d0 100644 --- a/charts/vald/templates/gateway/vald/deployment.yaml +++ b/charts/vald/templates/gateway/vald/deployment.yaml @@ -56,6 +56,8 @@ spec: {{- end }} affinity: {{- include "vald.affinity" .Values.gateway.affinity | nindent 8 }} + topologySpreadConstraints: + {{- toYaml .Values.gateway.topologySpreadConstraints | nindent 8 }} containers: - name: {{ .Values.gateway.name }} image: "{{ .Values.gateway.image.repository }}:{{ default .Values.defaults.image.tag .Values.gateway.image.tag }}" diff --git a/charts/vald/templates/manager/backup/daemonset.yaml b/charts/vald/templates/manager/backup/daemonset.yaml index 62e87f60899..07e7fe01857 100644 --- a/charts/vald/templates/manager/backup/daemonset.yaml +++ b/charts/vald/templates/manager/backup/daemonset.yaml @@ -49,6 +49,10 @@ spec: {{- $initContainers := dict "initContainers" .Values.backupManager.initContainers "Values" .Values "namespace" .Release.Namespace -}} {{- include "vald.initContainers" $initContainers | trim | nindent 8 }} {{- end }} + affinity: + {{- include "vald.affinity" .Values.backupManager.affinity | nindent 8 }} + topologySpreadConstraints: + {{- toYaml .Values.backupManager.topologySpreadConstraints | nindent 8 }} containers: - name: {{ .Values.backupManager.name }} image: "{{ .Values.backupManager.image.repository }}:{{ default .Values.defaults.image.tag .Values.backupManager.image.tag }}" diff --git a/charts/vald/templates/manager/backup/deployment.yaml b/charts/vald/templates/manager/backup/deployment.yaml index 21492b546a2..445425953ad 100644 --- a/charts/vald/templates/manager/backup/deployment.yaml +++ b/charts/vald/templates/manager/backup/deployment.yaml @@ -56,6 +56,8 @@ spec: {{- end }} affinity: {{- include "vald.affinity" .Values.backupManager.affinity | nindent 8 }} + topologySpreadConstraints: + {{- toYaml .Values.backupManager.topologySpreadConstraints | nindent 8 }} containers: - name: {{ .Values.backupManager.name }} image: "{{ .Values.backupManager.image.repository }}:{{ default .Values.defaults.image.tag .Values.backupManager.image.tag }}" diff --git a/charts/vald/templates/manager/compressor/daemonset.yaml b/charts/vald/templates/manager/compressor/daemonset.yaml index 6ca8ae31a2d..c35d12b7a38 100644 --- a/charts/vald/templates/manager/compressor/daemonset.yaml +++ b/charts/vald/templates/manager/compressor/daemonset.yaml @@ -49,6 +49,10 @@ spec: {{- $initContainers := dict "initContainers" .Values.compressor.initContainers "Values" .Values "namespace" .Release.Namespace -}} {{- include "vald.initContainers" $initContainers | trim | nindent 8 }} {{- end }} + affinity: + {{- include "vald.affinity" .Values.compressor.affinity | nindent 8 }} + topologySpreadConstraints: + {{- toYaml .Values.compressor.topologySpreadConstraints | nindent 8 }} containers: - name: {{ .Values.compressor.name }} image: "{{ .Values.compressor.image.repository }}:{{ default .Values.defaults.image.tag .Values.compressor.image.tag }}" diff --git a/charts/vald/templates/manager/compressor/deployment.yaml b/charts/vald/templates/manager/compressor/deployment.yaml index b08ab740482..f1a3b68e542 100644 --- a/charts/vald/templates/manager/compressor/deployment.yaml +++ b/charts/vald/templates/manager/compressor/deployment.yaml @@ -56,6 +56,8 @@ spec: {{- end }} affinity: {{- include "vald.affinity" .Values.compressor.affinity | nindent 8 }} + topologySpreadConstraints: + {{- toYaml .Values.compressor.topologySpreadConstraints | nindent 8 }} containers: - name: {{ .Values.compressor.name }} image: "{{ .Values.compressor.image.repository }}:{{ default .Values.defaults.image.tag .Values.compressor.image.tag }}" diff --git a/charts/vald/templates/manager/index/daemonset.yaml b/charts/vald/templates/manager/index/daemonset.yaml index 4ff8b8450f2..678452ef18c 100644 --- a/charts/vald/templates/manager/index/daemonset.yaml +++ b/charts/vald/templates/manager/index/daemonset.yaml @@ -49,6 +49,10 @@ spec: {{- $initContainers := dict "initContainers" .Values.indexManager.initContainers "Values" .Values "namespace" .Release.Namespace -}} {{- include "vald.initContainers" $initContainers | trim | nindent 8 }} {{- end }} + affinity: + {{- include "vald.affinity" .Values.indexManager.affinity | nindent 8 }} + topologySpreadConstraints: + {{- toYaml .Values.indexManager.topologySpreadConstraints | nindent 8 }} containers: - name: {{ .Values.indexManager.name }} image: "{{ .Values.indexManager.image.repository }}:{{ default .Values.defaults.image.tag .Values.indexManager.image.tag }}" diff --git a/charts/vald/templates/manager/index/deployment.yaml b/charts/vald/templates/manager/index/deployment.yaml index 2981baa0049..ce0a448c8e2 100644 --- a/charts/vald/templates/manager/index/deployment.yaml +++ b/charts/vald/templates/manager/index/deployment.yaml @@ -54,6 +54,8 @@ spec: {{- end }} affinity: {{- include "vald.affinity" .Values.indexManager.affinity | nindent 8 }} + topologySpreadConstraints: + {{- toYaml .Values.indexManager.topologySpreadConstraints | nindent 8 }} containers: - name: {{ .Values.indexManager.name }} image: "{{ .Values.indexManager.image.repository }}:{{ default .Values.defaults.image.tag .Values.indexManager.image.tag }}" diff --git a/charts/vald/templates/meta/daemonset.yaml b/charts/vald/templates/meta/daemonset.yaml index f12b097d150..58764553951 100644 --- a/charts/vald/templates/meta/daemonset.yaml +++ b/charts/vald/templates/meta/daemonset.yaml @@ -49,6 +49,10 @@ spec: {{- $initContainers := dict "initContainers" .Values.meta.initContainers "Values" .Values "namespace" .Release.Namespace -}} {{- include "vald.initContainers" $initContainers | trim | nindent 8 }} {{- end }} + affinity: + {{- include "vald.affinity" .Values.meta.affinity | nindent 8 }} + topologySpreadConstraints: + {{- toYaml .Values.meta.topologySpreadConstraints | nindent 8 }} containers: - name: {{ .Values.meta.name }} image: "{{ .Values.meta.image.repository }}:{{ default .Values.defaults.image.tag .Values.meta.image.tag }}" diff --git a/charts/vald/templates/meta/deployment.yaml b/charts/vald/templates/meta/deployment.yaml index 3890a1ba63e..dfad0d30974 100644 --- a/charts/vald/templates/meta/deployment.yaml +++ b/charts/vald/templates/meta/deployment.yaml @@ -56,6 +56,8 @@ spec: {{- end }} affinity: {{- include "vald.affinity" .Values.meta.affinity | nindent 8 }} + topologySpreadConstraints: + {{- toYaml .Values.meta.topologySpreadConstraints | nindent 8 }} containers: - name: {{ .Values.meta.name }} image: "{{ .Values.meta.image.repository }}:{{ default .Values.defaults.image.tag .Values.meta.image.tag }}" diff --git a/charts/vald/values.yaml b/charts/vald/values.yaml index 83530f2ff2c..880fcae7e32 100644 --- a/charts/vald/values.yaml +++ b/charts/vald/values.yaml @@ -536,6 +536,8 @@ gateway: - vald-gateway # gateway.affinity.podAntiAffinity.requiredDuringSchedulingIgnoredDuringExecution -- pod anti-affinity required scheduling terms requiredDuringSchedulingIgnoredDuringExecution: [] + # gateway.topologySpreadConstraints -- topology spread constraints of gateway pods + topologySpreadConstraints: [] # gateway.server_config -- server config (overrides defaults.server_config) server_config: servers: @@ -715,6 +717,8 @@ agent: - vald-agent-ngt # agent.affinity.podAntiAffinity.requiredDuringSchedulingIgnoredDuringExecution -- pod anti-affinity required scheduling terms requiredDuringSchedulingIgnoredDuringExecution: [] + # agent.topologySpreadConstraints -- topology spread constraints for agent pods + topologySpreadConstraints: [] # agent.server_config -- server config (overrides defaults.server_config) server_config: servers: @@ -867,6 +871,8 @@ discoverer: - vald-discoverer # discoverer.affinity.podAntiAffinity.requiredDuringSchedulingIgnoredDuringExecution -- pod anti-affinity required scheduling terms requiredDuringSchedulingIgnoredDuringExecution: [] + # discoverer.topologySpreadConstraints -- topology spread constraints of discoverer pods + topologySpreadConstraints: [] # discoverer.server_config -- server config (overrides defaults.server_config) server_config: servers: @@ -1011,6 +1017,8 @@ compressor: preferredDuringSchedulingIgnoredDuringExecution: [] # compressor.affinity.podAntiAffinity.requiredDuringSchedulingIgnoredDuringExecution -- pod anti-affinity required scheduling terms requiredDuringSchedulingIgnoredDuringExecution: [] + # compressor.topologySpreadConstraints -- topology spread constraints of compressor pods + topologySpreadConstraints: [] # compressor.server_config -- server config (overrides defaults.server_config) server_config: servers: @@ -1207,6 +1215,8 @@ backupManager: preferredDuringSchedulingIgnoredDuringExecution: [] # backupManager.affinity.podAntiAffinity.requiredDuringSchedulingIgnoredDuringExecution -- pod anti-affinity required scheduling terms requiredDuringSchedulingIgnoredDuringExecution: [] + # backupManager.topologySpreadConstraints -- topology spread constraints of backup manager pods + topologySpreadConstraints: [] # backupManager.server_config -- server config (overrides defaults.server_config) server_config: servers: @@ -1504,6 +1514,8 @@ indexManager: preferredDuringSchedulingIgnoredDuringExecution: [] # indexManager.affinity.podAntiAffinity.requiredDuringSchedulingIgnoredDuringExecution -- pod anti-affinity required scheduling terms requiredDuringSchedulingIgnoredDuringExecution: [] + # indexManager.topologySpreadConstraints -- topology spread constraints of index manager pods + topologySpreadConstraints: [] # indexManager.server_config -- server config (overrides defaults.server_config) server_config: servers: @@ -1697,6 +1709,8 @@ meta: preferredDuringSchedulingIgnoredDuringExecution: [] # meta.affinity.podAntiAffinity.requiredDuringSchedulingIgnoredDuringExecution -- pod anti-affinity required scheduling terms requiredDuringSchedulingIgnoredDuringExecution: [] + # meta.topologySpreadConstraints -- topology spread constraints of meta pods + topologySpreadConstraints: [] # meta.server_config -- server config (overrides defaults.server_config) server_config: servers: diff --git a/docs/guides/configurations.md b/docs/guides/configurations.md index 359e88ace35..e3a7e8d8271 100644 --- a/docs/guides/configurations.md +++ b/docs/guides/configurations.md @@ -197,10 +197,10 @@ Pod priorities are also useful for saving agent pods from eviction. By default, very high priority is set to agent pods in the Chart. -#### Pod anti-affinity +#### Pod scheduling It is recommended to schedule agent pods on different nodes as much as possible. -To achieve this, the following podAntiAffinity is set by default. +To achieve this, the following [podAntiAffinity][k8s-affinity-antiaffinity] is set by default. ```yaml agent: @@ -218,6 +218,22 @@ agent: - vald-agent-ngt ``` +It can be also achieved by using [pod topology spread constraints][k8s-topology-spread-constraints]. + +```yaml +agent: + topologySpreadConstraints: + - topologyKey: node + maxSkew: 1 + whenUnsatisfiable: ScheduleAnyway + labelSelector: + matchLabels: + app: vald-agent-ngt + affinity: + podAntiAffinity: + preferredDuringSchedulingIgnoredDuringExecution: [] # to disable default settings +``` + ### Gateway #### Ingress @@ -399,5 +415,7 @@ For further details, there are references of Helm values in GitHub Vald reposito [google-pprof]: https://github.com/google/pprof [prometheus-io]: https://prometheus.io/ [k8s-liveness-readiness]: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/ +[k8s-affinity-antiaffinity]: https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity +[k8s-topology-spread-constraints]: https://kubernetes.io/docs/concepts/workloads/pods/pod-topology-spread-constraints/ [yj-ngt]: https://github.com/yahoojapan/NGT [yj-ngt-wiki]: https://github.com/yahoojapan/NGT/wiki diff --git a/go.mod b/go.mod index 9b0327ad031..69f161bd302 100755 --- a/go.mod +++ b/go.mod @@ -55,7 +55,7 @@ require ( go.uber.org/goleak v1.0.0 golang.org/x/mod v0.3.0 // indirect golang.org/x/sys v0.0.0-20200202164722-d101bd2416d5 - golang.org/x/tools v0.0.0-20200515010526-7d3b6ebf133d // indirect + golang.org/x/tools v0.0.0-20200515220128-d3bf790afa53 // indirect gonum.org/v1/hdf5 v0.0.0-20200504100616-496fefe91614 gonum.org/v1/netlib v0.0.0-20200317120129-c5a04cffd98a // indirect gonum.org/v1/plot v0.7.0 diff --git a/go.sum b/go.sum index d8ef847b2bf..647c1c329a6 100644 --- a/go.sum +++ b/go.sum @@ -643,6 +643,8 @@ golang.org/x/tools v0.0.0-20191125144606-a911d9008d1f/go.mod h1:b+2E5dAYhXwXZwtn golang.org/x/tools v0.0.0-20191203134012-c197fd4bf371/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo= golang.org/x/tools v0.0.0-20200515010526-7d3b6ebf133d h1:n6zwymXmN9rCClNNmCWwV3qwMmBcRw/WeIGDK8Qnzk4= golang.org/x/tools v0.0.0-20200515010526-7d3b6ebf133d/go.mod h1:EkVYQZoAsY45+roYkvgYkIh4xh/qjgUK9TdY2XT94GE= +golang.org/x/tools v0.0.0-20200515220128-d3bf790afa53 h1:vmsb6v0zUdmUlXfwKaYrHPPRCV0lHq/IwNIf0ASGjyQ= +golang.org/x/tools v0.0.0-20200515220128-d3bf790afa53/go.mod h1:EkVYQZoAsY45+roYkvgYkIh4xh/qjgUK9TdY2XT94GE= golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543 h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4= From 48dbd44868d3bf220f363c1a203acc7d55ff3e17 Mon Sep 17 00:00:00 2001 From: vdaas-ci Date: Mon, 18 May 2020 03:57:34 +0000 Subject: [PATCH 2/3] :robot: Automatically update k8s manifests Signed-off-by: vdaas-ci --- k8s/agent/statefulset.yaml | 1 + k8s/discoverer/deployment.yaml | 1 + k8s/gateway/vald/deployment.yaml | 1 + k8s/manager/backup/deployment.yaml | 1 + k8s/manager/compressor/deployment.yaml | 1 + k8s/manager/index/deployment.yaml | 1 + k8s/meta/deployment.yaml | 1 + 7 files changed, 7 insertions(+) diff --git a/k8s/agent/statefulset.yaml b/k8s/agent/statefulset.yaml index ccfc590f7c4..753d7ac1f29 100644 --- a/k8s/agent/statefulset.yaml +++ b/k8s/agent/statefulset.yaml @@ -62,6 +62,7 @@ spec: topologyKey: kubernetes.io/hostname weight: 100 requiredDuringSchedulingIgnoredDuringExecution: [] + topologySpreadConstraints: [] containers: - name: vald-agent-ngt image: "vdaas/vald-agent-ngt:nightly" diff --git a/k8s/discoverer/deployment.yaml b/k8s/discoverer/deployment.yaml index 4410ca53831..54aab44cef5 100644 --- a/k8s/discoverer/deployment.yaml +++ b/k8s/discoverer/deployment.yaml @@ -61,6 +61,7 @@ spec: topologyKey: kubernetes.io/hostname weight: 100 requiredDuringSchedulingIgnoredDuringExecution: [] + topologySpreadConstraints: [] containers: - name: vald-discoverer image: "vdaas/vald-discoverer-k8s:nightly" diff --git a/k8s/gateway/vald/deployment.yaml b/k8s/gateway/vald/deployment.yaml index b639a47dfde..317a57ad7e3 100644 --- a/k8s/gateway/vald/deployment.yaml +++ b/k8s/gateway/vald/deployment.yaml @@ -105,6 +105,7 @@ spec: topologyKey: kubernetes.io/hostname weight: 100 requiredDuringSchedulingIgnoredDuringExecution: [] + topologySpreadConstraints: [] containers: - name: vald-gateway image: "vdaas/vald-gateway:nightly" diff --git a/k8s/manager/backup/deployment.yaml b/k8s/manager/backup/deployment.yaml index f972b87172a..216a46a064c 100644 --- a/k8s/manager/backup/deployment.yaml +++ b/k8s/manager/backup/deployment.yaml @@ -73,6 +73,7 @@ spec: podAntiAffinity: preferredDuringSchedulingIgnoredDuringExecution: [] requiredDuringSchedulingIgnoredDuringExecution: [] + topologySpreadConstraints: [] containers: - name: vald-manager-backup image: "vdaas/vald-manager-backup-mysql:nightly" diff --git a/k8s/manager/compressor/deployment.yaml b/k8s/manager/compressor/deployment.yaml index 5f16119db61..e5f06b5bebc 100644 --- a/k8s/manager/compressor/deployment.yaml +++ b/k8s/manager/compressor/deployment.yaml @@ -63,6 +63,7 @@ spec: podAntiAffinity: preferredDuringSchedulingIgnoredDuringExecution: [] requiredDuringSchedulingIgnoredDuringExecution: [] + topologySpreadConstraints: [] containers: - name: vald-manager-compressor image: "vdaas/vald-manager-compressor:nightly" diff --git a/k8s/manager/index/deployment.yaml b/k8s/manager/index/deployment.yaml index c78bd5200f4..01a2f07a4f8 100644 --- a/k8s/manager/index/deployment.yaml +++ b/k8s/manager/index/deployment.yaml @@ -75,6 +75,7 @@ spec: podAntiAffinity: preferredDuringSchedulingIgnoredDuringExecution: [] requiredDuringSchedulingIgnoredDuringExecution: [] + topologySpreadConstraints: [] containers: - name: vald-manager-index image: "vdaas/vald-manager-index:nightly" diff --git a/k8s/meta/deployment.yaml b/k8s/meta/deployment.yaml index 4f023d163c2..4878a52cd7b 100644 --- a/k8s/meta/deployment.yaml +++ b/k8s/meta/deployment.yaml @@ -73,6 +73,7 @@ spec: podAntiAffinity: preferredDuringSchedulingIgnoredDuringExecution: [] requiredDuringSchedulingIgnoredDuringExecution: [] + topologySpreadConstraints: [] containers: - name: vald-meta image: "vdaas/vald-meta-redis:nightly" From e1d42bca8f862971c5d51ca27360fb88cfc64d0f Mon Sep 17 00:00:00 2001 From: Kiichiro YUKAWA Date: Mon, 18 May 2020 13:15:33 +0900 Subject: [PATCH 3/3] :bug: fix ngt distance_type (#384) Signed-off-by: vankichi --- example/helm/values-scylla.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/example/helm/values-scylla.yaml b/example/helm/values-scylla.yaml index 9c30492cd88..a17d0e5c6d4 100644 --- a/example/helm/values-scylla.yaml +++ b/example/helm/values-scylla.yaml @@ -34,7 +34,7 @@ agent: # The number of dimensions for feature vector of fashion-mnist dataset. dimension: 784 # We use L2-Norm for distance_type. - distance_type: 12 + distance_type: l2 # the type of fashion-mnist's feature vectors. object_type: float