Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(group): add draw to output toggle #762

Merged
merged 2 commits into from
Sep 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/application/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,7 @@ export default {
return 512;
}
};

export const GROUP_DISABLED = 0;
export const GROUP_ENABLED = 1;
export const GROUP_DRAW_TO_OUTPUT = 2;
3 changes: 2 additions & 1 deletion src/application/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import PromiseWorker from "promise-worker-transferable";
import Vue from "vue";
import { ipcRenderer } from "electron";
import { app } from "@electron/remote";
import { GROUP_ENABLED } from "./constants";

let imageBitmap;
const imageBitmapQueue = [];
Expand Down Expand Up @@ -132,7 +133,7 @@ export default class ModV {
};

// Make the default group
this.store.dispatch("groups/createGroup", { enabled: true });
this.store.dispatch("groups/createGroup", { enabled: GROUP_ENABLED });

window.addEventListener("beforeunload", () => true);
}
Expand Down
8 changes: 4 additions & 4 deletions src/application/worker/loop.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import get from "lodash.get";
import store from "./store";
import map from "../utils/map";
import constants from "../constants";
import constants, { GROUP_DISABLED, GROUP_ENABLED } from "../constants";
import { applyWindow } from "meyda/src/utilities";

const meyda = { windowing: applyWindow };
Expand Down Expand Up @@ -142,7 +142,7 @@ function loop(delta, features, fftOutput) {
const isGalleryGroup = group.name === constants.GALLERY_GROUP_NAME;

const groupModulesLength = group.modules.length;
if (!group.enabled || group.alpha < 0.001) {
if (group.enabled === GROUP_DISABLED || group.alpha < 0.001) {
continue;
}

Expand Down Expand Up @@ -286,7 +286,7 @@ function loop(delta, features, fftOutput) {
}
}

if (!group.hidden) {
if (!group.hidden && group.enabled === GROUP_ENABLED) {
lastCanvas = drawTo.canvas;
}
}
Expand All @@ -307,7 +307,7 @@ function loop(delta, features, fftOutput) {
modules
} = group;
const groupModulesLength = modules.length;
if (!enabled || groupModulesLength < 1 || !(alpha > 0)) {
if (enabled !== GROUP_ENABLED || groupModulesLength < 1 || !(alpha > 0)) {
continue;
}

Expand Down
10 changes: 4 additions & 6 deletions src/application/worker/store/modules/groups.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import SWAP from "./common/swap";
import store from "../";
import constants from "../../../constants";
import constants, { GROUP_DISABLED } from "../../../constants";
import uuidv4 from "uuid/v4";
import { applyExpression } from "../../../utils/apply-expression";

Expand All @@ -15,7 +15,8 @@ import { applyExpression } from "../../../utils/apply-expression";
*
* @property {Array} modules The draw order of the Modules contained within the Group
*
* @property {Boolean} enabled Indicates whether the Group should be drawn
* @property {Number} enabled Indicates whether the Group should be drawn. 0: not drawn,
* 1: drawn, 2: not drawn to output canvas
*
* @property {Number} alpha The level of opacity, between 0 and 1, the Group should
* be drawn at
Expand All @@ -34,9 +35,6 @@ import { applyExpression } from "../../../utils/apply-expression";
*
* @property {String} compositeOperation The {@link Blendmode} the Group muxes with
*
* @property {Boolean} drawToOutput Indicates whether the Group should draw to the output
* canvas
*
* @property {String} drawToCanvasId The ID of the auxillary Canvas to draw the Group to,
* null indicates the Group should draw to the main output
*
Expand Down Expand Up @@ -133,7 +131,7 @@ const actions = {
name,
id,
clearing: args.clearing || false,
enabled: args.enabled || false,
enabled: Number(args.enabled) || GROUP_DISABLED,
hidden: args.hidden || false,
modules: args.modules || [],
inherit,
Expand Down
6 changes: 4 additions & 2 deletions src/components/GalleryItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
</template>

<script>
import { GROUP_ENABLED, GROUP_DISABLED } from "../application/constants.js";

export default {
props: ["moduleName", "groupId"],

Expand Down Expand Up @@ -95,7 +97,7 @@ export default {
groupId: this.groupId,
data: {
drawToCanvasId: this.outputId,
enabled: true
enabled: GROUP_ENABLED
}
});

Expand All @@ -116,7 +118,7 @@ export default {
this.$modV.store.commit("groups/UPDATE_GROUP", {
groupId: this.groupId,
data: {
enabled: false
enabled: GROUP_DISABLED
}
});
},
Expand Down
7 changes: 6 additions & 1 deletion src/components/Group.vue
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,12 @@
</grid>
</div>
<div class="group__left">
<Checkbox class="group__enabledCheckbox" v-model="enabled" />
<Checkbox
class="group__enabledCheckbox"
v-model="enabled"
allowPartial="true"
title="alt-click to skip drawing to output canvas"
/>
<button
class="group__controlsButton"
:class="{ 'group__controlsButton-hidden': !controlsShown }"
Expand Down
80 changes: 62 additions & 18 deletions src/components/inputs/Checkbox.vue
Original file line number Diff line number Diff line change
@@ -1,17 +1,62 @@
<template>
<label>
<input
type="checkbox"
@input="$emit('input', $event.target.checked)"
:checked="value"
/>
<span></span>
<label @mousedown="mousedown">
<span :class="spanClassName"></span>
</label>
</template>

<script>
export default {
props: ["value"]
props: {
value: {
type: Number,
required: true
},

allowPartial: {
type: Boolean,
default: false
}
},
data() {
return {
classNames: {
0: "off",
1: "on",
2: "partial"
}
};
},

computed: {
spanClassName() {
let inferredValue = this.value;

// for backwards compatibility with the old Checkbox control which used true or false only
if (this.value === true || this.value === false) {
inferredValue = Number(inferredValue);
}

return this.classNames[inferredValue];
}
},

methods: {
mousedown(e) {
const { altKey } = e;

let value = this.value;

if (this.allowPartial && altKey) {
value = 2;
} else if (value || !value) {
value = Number(!value);
} else if (value === 2) {
value = 0;
}

this.$emit("input", value);
}
}
};
</script>

Expand All @@ -34,7 +79,7 @@ label.light {
background: #363636;
}

input:checked + span::before {
span.on::before {
content: "";
width: 10px;
height: 4px;
Expand All @@ -47,16 +92,15 @@ input:checked + span::before {
transform: translateX(2px) translateY(3px) rotate(-45deg);
}

/* input:checked + span::after {
span.partial::before {
content: "";
width: 15px;
height: 15px;
width: 10px;
height: 4px;
display: inline-block;
position: absolute;
top: 2px;
right: 3px;
border-top: 2px solid white;
transform: rotate(-45deg);
transform-origin: right top;
} */
top: 0;
left: 0;
border-bottom: 2px solid white;
transform: translateX(3px) translateY(3px);
}
</style>