Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for /dg /ds /di #216

Open
avivanoff opened this issue Nov 20, 2023 · 4 comments
Open

Support for /dg /ds /di #216

avivanoff opened this issue Nov 20, 2023 · 4 comments

Comments

@avivanoff
Copy link

signtool.exe has a set of options for producing/signing/ingesting digests. It is imperative AzureSignTool has the same support for advanced singing workflows.

@vcsjones
Copy link
Owner

producing/signing/ingesting digests

I know what these flags do, but I don't see what AzureSignTool can do with them. AzureSignTool is all about signing something with Azure Key Vault. When you use digest signing, you are taking the the signing step out of the equation. What AzureSignTool would end up doing is exactly what regular signtool does.

How would these flags benefit AzureSignTool users, as opposed to continuing to use regular signtool?

@clairernovotny
Copy link
Collaborator

Please post these suggestions to https://github.com/dotnet/sign. That tool is intended to supersede AzureSignTool, NuGetKeyVaultSignTool, and several others.

@sopelt
Copy link

sopelt commented Jan 24, 2024

Thanks for the heads up @clairernovotny .
Is there any kind of roadmap/status in terms of that migration? We have been happily using AzureSignTool for years to sign various artifacts ... the new project is very welcome if it furthers key vault for such scenarios but I am unsure if attempting to replace it in the various pipelines just now.

@uecasm
Copy link

uecasm commented Aug 13, 2024

@vcsjones I don't have any particular use case for it myself, but I imagine a useful implementation of this would be to add support for /ds alone (i.e. use the key vault to actually sign a digest produced by signtool /dg, in a format compatible with signtool /di). Perhaps this might allow some advanced scenarios not currently supported, such as multi-signing? (Though there's also less point in doing that these days, at least for SHA1 compatibility purposes.)

Though having said that, once you're splitting the operations up rather than doing an all-in-one, I imagine you could use Azure CLI for the signing step, since that's essentially the same thing AzureSignTool would be doing "under the hood" anyway. AzureSignTool remains a convenient way to do all three steps in one tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants