Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve documentation on volatile dependence #133

Open
chrishavlin opened this issue Aug 29, 2024 · 1 comment · May be fixed by #150
Open

improve documentation on volatile dependence #133

chrishavlin opened this issue Aug 29, 2024 · 1 comment · May be fixed by #150
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@chrishavlin
Copy link
Member

The current behavior is fairly confusing -- it's hard to know when and where VBR.in.SV.Ch2o gets used.

Also, with #92 , we'll be getting separate Ch2o fields for water in melt and solid phases.

So, would be good to add a page to documentation about water (and generally volatiles) describing in detail how it will impact results.

@chrishavlin chrishavlin added the documentation Improvements or additions to documentation label Aug 29, 2024
@chrishavlin chrishavlin self-assigned this Aug 29, 2024
@chrishavlin
Copy link
Member Author

Copying from a slack answer for future reference:

for the pre_melt scaling, water will only have an affect through the solidus that you provide -- no direct effect of water on maxwell time.

For andrade_psp: andrade_psp will not depend on water content.

For eburgers_psp, the default behavior will not depend on water content. But if you set the paramter VBR.in.anelastic.eburgers_psp.useJF10visc=0 and provide a viscous method, VBR.in.viscous.methods_list = {'HK2003';}, then the maxwell time for the anelastic calculation will use the diffusion creep viscosity from HK2003, which will have a dependence on water if you set Ch2o.

For xfit_mxw, this method just directly pulls the diffusion creep viscosity of the viscosity calculation in VBR.in.viscous.methods_list, so if you set HK2003 and a nonzero VBR.in.SV.Ch2o field then you should see some dependence on water.

Ch2o units are ppm.

@chrishavlin chrishavlin linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant