Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf2bpf calls should support local stack variables in the callee #720

Closed
dthaler opened this issue Oct 7, 2024 · 0 comments · Fixed by #721
Closed

bpf2bpf calls should support local stack variables in the callee #720

dthaler opened this issue Oct 7, 2024 · 0 comments · Fixed by #721

Comments

@dthaler
Copy link
Contributor

dthaler commented Oct 7, 2024

Issue #451 covered adding basic bpf2bpf call support and PR #608 added support and tests when the callee just uses registers.

However, local stack variables are not correctly supported, as r10 is not changed. Thus, variables in the callee overwrite stack space in the caller.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix stack access with bpf2bpf calls dthaler/ebpf-verifier
1 participant
@dthaler