From e92408ce0fc8c26a6c8b2e1bc0ef59ea9f8d3072 Mon Sep 17 00:00:00 2001 From: Alan Jowett Date: Sat, 9 Nov 2024 14:18:17 -0800 Subject: [PATCH] PR feedback Signed-off-by: Alan Jowett --- src/asm_parse.cpp | 1 - test-data/add.yaml | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/asm_parse.cpp b/src/asm_parse.cpp index 2eac47383..e8de828c9 100644 --- a/src/asm_parse.cpp +++ b/src/asm_parse.cpp @@ -228,7 +228,6 @@ InstructionOrConstraintsSet parse_instruction(const std::string& line, if (regex_match(text, m, regex(REQUIRE))) { std::string constraints = m[1]; std::set constraint_set; - std::vector numeric_ranges; std::regex re(R"(\s*,\s*)"); std::sregex_token_iterator first{constraints.begin(), constraints.end(), re, -1}, last; for (; first != last; ++first) { diff --git a/test-data/add.yaml b/test-data/add.yaml index 5bbb858af..bdb920061 100644 --- a/test-data/add.yaml +++ b/test-data/add.yaml @@ -213,6 +213,7 @@ code: r2 = 2 require [r2.type=number, r2.svalue=2, r2.uvalue=r2.svalue] r1 += r2 + # Using 2 instead of 3 to validate that verification fails at an intermediate step. require [r1.type=number, r1.svalue=2, r1.uvalue=r1.svalue] r0 = r1 @@ -228,4 +229,4 @@ post: - r2.uvalue=2 messages: - - "3: Concrete invariants do not match abstract invariants" + - "4: Concrete invariants do not match abstract invariants"