Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicat ignores user-provided values for -r/--repository (always uses the default) #15

Closed
vaultah opened this issue Jul 17, 2022 · 0 comments · Fixed by #16
Closed
Labels
bug Something isn't working

Comments

@vaultah
Copy link
Owner

vaultah commented Jul 17, 2022

Description

The change introduced in #13 caused a regression: no matter what users pass to the -r/--repository CLI argument, Replicat will attempt to perform actions on the repository in the current working directory, which is the default behaviour.

Cause

This is due to a bug in the Python's argparse module. Come read python/cpython#89398, it's amusing.

Affected versions

main, 1.2.1

Solution

Force Replicat to parse the -r/--repository argument twice. We'll be able to revert this solution when (if) Python core developers find time to fix (or review PRs that fix) that argparse bug. Let's not forget to verify that the fix actually works. Also, we should add tests for Replicat's CLI.

@vaultah vaultah added the bug Something isn't working label Jul 17, 2022
@vaultah vaultah linked a pull request Jul 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant