Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui/select): support arrow-icon #738

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Conversation

filway
Copy link
Contributor

@filway filway commented Oct 25, 2022

Checklist


  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information


@vercel
Copy link

vercel bot commented Oct 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
varlet ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 9:53AM (UTC)
varlet-ui-playground ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 9:53AM (UTC)

@haoziqaq
Copy link
Member

maybe the same as append-icon slot ?

@haoziqaq
Copy link
Member

I suggest the name of the slot is arrow-icon, and needs to support scope parameters. otherwise, it is impossible to know whether to focus. The way I am expecting to use is as follows

<var-select>
  <template #arrow-icon="{ focus }">
     <var-icon :class="{ rotate: focus }"/>
  </template>
</var-select>

@haoziqaq
Copy link
Member

And you should complete the type related definitions in packages/varlet-ui/types/select.d.ts

@haoziqaq haoziqaq merged commit 68ceec9 into varletjs:dev Oct 25, 2022
@haoziqaq haoziqaq changed the title feat(ui/select): support suffix-icon feat(ui/select): support arrow-icon Oct 25, 2022
@haoziqaq
Copy link
Member

thx bro~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants