Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add defineConfig for type helper #721

Merged
merged 1 commit into from
Oct 13, 2022
Merged

feat(cli): add defineConfig for type helper #721

merged 1 commit into from
Oct 13, 2022

Conversation

nonzzz
Copy link
Contributor

@nonzzz nonzzz commented Oct 13, 2022 •
edited
Loading

Checklist

  • Fix linting errors
  • Fix sub package varlet-ui tsconfig.json warnings.
  • varlet-cli extra bin.ts and index.ts. ( Add defineConfig func
  • Fix varlet-cli document host types error.
  • Update create template config part.

Change information

const { defineConfig } = require('@varlet/cli')

module.exports = defineConfig({})

#720

@vercel
Copy link

vercel bot commented Oct 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
varlet ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 2:11AM (UTC)
varlet-ui-playground ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 2:11AM (UTC)

@nonzzz
Copy link
Contributor Author

nonzzz commented Oct 13, 2022

@haoziqaq cc. Pls

BeADre
BeADre reviewed Oct 13, 2022
View reviewed changes
packages/varlet-ui/tsconfig.json
@@ -1,6 +1,7 @@
{
"compilerOptions": {
"module": "esnext",
"outDir": "./dist",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe outDir is unnecessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately. when we set allowJs as true. The typescript will warn the overwrite in console. Because typescript or others bundle tools who can read tscofig.json. Will overwrite the bundle file. ReferReason

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According the following issue. I think set the field outDir is quickest way. Or may use exclude option repalce the outDir?

@BeADre
Copy link
Member

BeADre commented Oct 13, 2022

LGTM

@BeADre BeADre merged commit 84579f4 into varletjs:dev Oct 13, 2022
@nonzzz nonzzz deleted the feat/load branch October 13, 2022 02:55
@nonzzz nonzzz mentioned this pull request Oct 13, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeADre BeADre BeADre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nonzzz @BeADre