feat(ui/col): add a direction API for col #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
coder-fang
changed the title
|
The |
BeADre
reviewed
Oct 6, 2022
packages/varlet-ui/src/col/Col.vue
Outdated
| @@ -43,7 +44,7 @@ export default defineComponent({ | |||
| const span: ComputedRef<number> = computed(() => toNumber(props.span)) | |||
| const offset: ComputedRef<number> = computed(() => toNumber(props.offset)) | |||
| const { row, bindRow } = useRow() | |||
|
|
|||
| const direction: ComputedRef<string> = computed(() => toString(props.direction)) | |||
BeADre
reviewed
Oct 6, 2022
packages/varlet-ui/src/col/props.ts
Outdated
| @@ -1,6 +1,8 @@ | |||
| import type { PropType } from 'vue' | |||
| import { SizeDescriptor } from './provide' | |||
|
|
|||
| export type SpaceDirection = 'row' | 'column' | |||
BeADre
reviewed
Oct 6, 2022
packages/varlet-ui/src/row/props.ts
Outdated
Comment on lines
29
to
32
| direction: { | ||
| type: [String], | ||
| default: 'row', | ||
| }, |
BeADre
reviewed
Oct 6, 2022
| @@ -8,6 +8,7 @@ export type SizeDescriptor = { | |||
| export interface ColProps extends BasicAttributes { | |||
| span?: string | number | |||
| offset?: string | number | |||
| direction?: string | |||
BeADre
approved these changes
Oct 7, 2022
|
This pr has some problem, I will fix it after i merging. Please focus on the following commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Change information