Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improved Menu performance and Flip bugs #680

Merged
merged 10 commits into from
Sep 5, 2022
Merged

perf: Improved Menu performance and Flip bugs #680

merged 10 commits into from
Sep 5, 2022

Conversation

wangKBweb
Copy link
Member

Checklist


  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information


@vercel
Copy link

vercel bot commented Sep 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
varlet ✅ Ready (Inspect) Visit Preview Sep 4, 2022 at 7:46PM (UTC)
varlet-ui-playground ✅ Ready (Inspect) Visit Preview Sep 4, 2022 at 7:46PM (UTC)

@codecov-commenter
Copy link

Codecov Report

Merging #680 (cedcb66) into v2.0 (91534b8) will decrease coverage by 0.04%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##             v2.0     #680      +/-   ##
==========================================
- Coverage   79.29%   79.24%   -0.05%     
==========================================
  Files         240      240              
  Lines        4959     4949      -10     
  Branches     1007     1004       -3     
==========================================
- Hits         3932     3922      -10     
- Misses        210      214       +4     
+ Partials      817      813       -4     
Impacted Files Coverage Δ
packages/varlet-ui/src/menu-v2/props.ts 100.00% <ø> (ø)
packages/varlet-ui/src/select/example/index.vue 64.51% <ø> (+2.01%) ⬆️
packages/varlet-ui/src/select/Select.vue 80.46% <50.00%> (+0.89%) ⬆️
packages/varlet-ui/src/menu-v2/MenuV2.vue 77.57% <60.00%> (-0.87%) ⬇️
packages/varlet-ui/src/menu/Menu.tsx 84.00% <0.00%> (-6.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@haoziqaq haoziqaq merged commit 45ac406 into varletjs:v2.0 Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants