Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ui/list): add class and call function #376

Merged
merged 3 commits into from
Apr 3, 2022
Merged

perf(ui/list): add class and call function #376

merged 3 commits into from
Apr 3, 2022

Conversation

alec1815
Copy link
Contributor

@alec1815 alec1815 commented Apr 3, 2022

Checklist


  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information


@github-actions
Copy link

github-actions bot commented Apr 3, 2022

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2022

Codecov Report

Merging #376 (171bac7) into dev (16a8bed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #376   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files         209      209           
  Lines        4919     4921    +2     
  Branches     1033     1030    -3     
=======================================
+ Hits         4742     4744    +2     
  Misses        177      177           
Impacted Files Coverage Δ
packages/varlet-ui/src/list/List.vue 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16a8bed...171bac7. Read the comment docs.

@haoziqaq
Copy link
Member

haoziqaq commented Apr 3, 2022

packages/varlet-ui/src/list/List.vue#L33

'call' is defined but never used

@alec1815 alec1815 changed the title perf(ui/list): add class perf(ui/list): add class and call function Apr 3, 2022
@haoziqaq haoziqaq merged commit 387af67 into varletjs:dev Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants