Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui/uploader): add a hide-list props for uploader components #335

Merged
merged 11 commits into from
Mar 13, 2022
Merged

feat(ui/uploader): add a hide-list props for uploader components #335

merged 11 commits into from
Mar 13, 2022

Conversation

zhangmo8
Copy link
Member

@zhangmo8 zhangmo8 commented Mar 12, 2022

Checklist


  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information


I add the hide-list props and provided docs and cases in the uploader components. When user need render the file list, they can hide the list and render the list thenself.

Maybe slot is more appropriate. But i think it's more unrestrained now.

@github-actions
Copy link

@haoziqaq
Copy link
Member

Ok, good idea.
This pr will be merged after the next version release and you should update snapshot.

@zhangmo8
Copy link
Member Author

The other submitted files have been merged into my fork, so I seem to have overwritten the code of image preview in the middle. I'm sorry

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2022

Codecov Report

Merging #335 (531a0f0) into dev (06a2cc7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #335   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files         209      209           
  Lines        4870     4874    +4     
  Branches     1040     1041    +1     
=======================================
+ Hits         4687     4691    +4     
  Misses        183      183           
Impacted Files Coverage Δ
packages/varlet-ui/src/uploader/props.ts 100.00% <ø> (ø)
packages/varlet-ui/src/uploader/Uploader.vue 94.95% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a2cc7...531a0f0. Read the comment docs.

@haoziqaq haoziqaq merged commit 70bf77a into varletjs:dev Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants