-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: split frequency type further #1784
Conversation
deps-report 🔍Commit scanned: 332b4c5 Vulnerable dependencies4 dependencies have vulnerabilities 😱
Outdated dependencies36 outdated dependencies found (including 13 outdated major versions)😢
|
255e5fa
to
2e34360
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1784 +/- ##
=====================================
Coverage 91% 91%
=====================================
Files 646 647 +1
Lines 36475 36517 +42
=====================================
+ Hits 33430 33470 +40
- Misses 3045 3047 +2
|
gnomad_exomes?: unknown; | ||
gnomad_genomes?: unknown; | ||
gnomad_mitochondrial?: unknown; | ||
helixmtdb?: unknown; | ||
inhouse?: unknown; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@holtgrewe it looks like type introspection did not work here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @Gregoor Will fix on Wednesday. Will be the equivalent of
varfish-server/backend/seqvars/models.py
Line 21 in 3c325fe
class GnomadNuclearFrequencySettings(pydantic.BaseModel): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should work after #1786
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
No description provided.