Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split frequency type further #1784

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

holtgrewe
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Jul 8, 2024

deps-report 🔍

Commit scanned: 332b4c5
ℹ️ Python version 3.10 is used by your project but the latest version is 3.12.

Vulnerable dependencies

4 dependencies have vulnerabilities 😱
Dependency Advisory Versions impacted
djangorestframework (transitive) Affected versions of the package djangorestframework are vulnerable to Cross-site Scripting (XSS) via the break_long_headers template filter due to improper input sanitization before splitting and joining with <3.15.2
jinja2 (transitive) In Jinja2, the from_string function is prone to Server Side Template Injection (SSTI) where it takes the "source" parameter as a template object, renders it, and then returns it. The attacker can exploit it with {{INJECTION COMMANDS}} in a URI. NOTE: The maintainer and multiple third parties believe that this vulnerability isn't valid because users shouldn't use untrusted templates without sandboxing. >=0
pyopenssl (transitive) CVE-2023-6129 affects PyOpenSSL versions starting from 22.0.0 due to a vulnerability in the POLY1305 MAC algorithm on PowerPC CPUs. This issue could lead to state corruption in applications, causing inaccurate outcomes or service disruptions. Attackers need specific conditions to exploit this flaw, including the ability to manipulate the algorithm's use and reliance on certain system registers by the application. >=22.0.0
sqlalchemy Sqlalchemy 2.0.0b1 avoids leaking cleartext passwords to the open for careless uses of str(engine.URL()) in logs and prints. sqlalchemy/sqlalchemy#8563 <2.0.0b1

Outdated dependencies

36 outdated dependencies found (including 13 outdated major versions)😢
Dependency Installed version Latest version
argon2-cffi (transitive) 21.3.0 23.1.0
billiard (transitive) 3.6.4.0 4.2.0
crispy-bootstrap4 (transitive) 2022.1 2024.1
django 3.2.25 5.0.6
mistune (transitive) 2.0.5 3.0.2
packaging (transitive) 23.2 24.1
protobuf 3.20.3 5.27.2
setuptools (transitive) 67.6.1 70.2.0
sphinx (transitive) 6.2.1 7.3.7
sphinx-rtd-theme (transitive) 1.2.2 2.0.0
sqlalchemy 1.4.52 2.0.31
unidecode (transitive) 0.4.21 1.3.8
xmlschema (transitive) 2.5.1 3.3.1
Dependency Installed version Latest version
botocore (transitive) 1.34.131 1.34.140
celery (transitive) 5.2.7 5.4.0
django-autocomplete-light (transitive) 3.9.4 3.11.0
django-crispy-forms (transitive) 2.0 2.2
django-db-file-storage (transitive) 0.5.5 0.5.6.1
django-debug-toolbar 4.3.0 4.4.5
django-environ (transitive) 0.10.0 0.11.2
django-iconify (transitive) 0.1.1 0.4
django-model-utils (transitive) 4.3.1 4.5.1
django-plugins-bihealth 0.4.0 0.5.2
django-postgres-copy 2.3.7 2.7.4
django-pydantic-field 0.3.9 0.3.10
djangorestframework (transitive) 3.14.0 3.15.2
docutils (transitive) 0.18.1 0.21.2
drf-keyed-list-bihealth 0.1.1 0.2.1
markdown (transitive) 3.4.1 3.6
requests-http-signature 0.2.0 0.7.1
rpds-py (transitive) 0.18.1 0.19.0
rules (transitive) 3.3 3.4
sentry-sdk 2.7.1 2.8.0
trio (dev,transitive) 0.25.1 0.26.0
versioneer (transitive) 0.28 0.29
wheel (transitive) 0.40.0 0.43.0

Logs

@holtgrewe holtgrewe force-pushed the feat-split-frequency-type-further branch from 255e5fa to 2e34360 Compare July 8, 2024 13:26
@holtgrewe holtgrewe enabled auto-merge (squash) July 8, 2024 13:26
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 98.07692% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91%. Comparing base (b1fa2b5) to head (2e34360).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1784   +/-   ##
=====================================
  Coverage     91%     91%           
=====================================
  Files        646     647    +1     
  Lines      36475   36517   +42     
=====================================
+ Hits       33430   33470   +40     
- Misses      3045    3047    +2     
Files Coverage Δ
backend/config/urls.py 77% <ø> (-2%) ⬇️
backend/seqvars/factory_defaults.py 86% <ø> (ø)
...kend/seqvars/migrations/0002_auto_20240708_1305.py 100% <100%> (ø)
backend/seqvars/models.py 98% <100%> (+<1%) ⬆️
backend/seqvars/serializers.py 98% <100%> (-1%) ⬇️
backend/seqvars/tests/factories.py 99% <100%> (+<1%) ⬆️
...vars/tests/snapshots/snap_test_factory_defaults.py 100% <ø> (ø)
...end/seqvars/tests/snapshots/snap_test_views_api.py 100% <ø> (ø)
backend/seqvars/tests/test_permissions_api.py 100% <100%> (ø)
backend/seqvars/tests/test_serializers.py 100% <100%> (ø)
... and 1 more

@holtgrewe holtgrewe disabled auto-merge July 8, 2024 14:03
@holtgrewe holtgrewe merged commit 3c325fe into main Jul 8, 2024
12 checks passed
@holtgrewe holtgrewe deleted the feat-split-frequency-type-further branch July 8, 2024 14:03
Comment on lines +1960 to +1964
gnomad_exomes?: unknown;
gnomad_genomes?: unknown;
gnomad_mitochondrial?: unknown;
helixmtdb?: unknown;
inhouse?: unknown;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@holtgrewe it looks like type introspection did not work here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Gregoor Will fix on Wednesday. Will be the equivalent of

class GnomadNuclearFrequencySettings(pydantic.BaseModel):

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work after #1786

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants