From ee015f5b91fdce6f0b55e9eac6b7b9579f541c3b Mon Sep 17 00:00:00 2001
From: Oliver Stolpe <oliver.stolpe@bih-charite.de>
Date: Mon, 21 Oct 2024 16:24:57 +0200
Subject: [PATCH] feat: quick preset editor must force values to be set on
 creation (#2028)

---
 .../components/FilterForm/QuickPresets.vue    | 26 ++++++++++++++++++-
 .../components/QueryPresets/SetEditor.vue     |  1 -
 .../QueryPresets/SetQuickPresets.vue          | 22 ++++++++++++++++
 3 files changed, 47 insertions(+), 2 deletions(-)

diff --git a/frontend/src/variants/components/FilterForm/QuickPresets.vue b/frontend/src/variants/components/FilterForm/QuickPresets.vue
index ef00d1c77..c715440e1 100644
--- a/frontend/src/variants/components/FilterForm/QuickPresets.vue
+++ b/frontend/src/variants/components/FilterForm/QuickPresets.vue
@@ -323,6 +323,30 @@ const quickPresetWrapper = computed({
   },
 })
 
+const quickPresetsComplete = computed(() => {
+  const result = {}
+  for (const [name, theQuickPresets] of Object.entries(props.quickPresets)) {
+    let skip = false
+    for (const key of [
+      'inheritance',
+      'frequency',
+      'impact',
+      'quality',
+      'chromosomes',
+      'flagsetc',
+    ]) {
+      if (!theQuickPresets[key]) {
+        skip = true
+        break
+      }
+    }
+    if (!skip) {
+      result[name] = theQuickPresets
+    }
+  }
+  return result
+})
+
 /** Refresh all presets. */
 const refreshAllRefs = () => {
   refreshInheritanceRef()
@@ -366,7 +390,7 @@ onMounted(() => {
         v-model="quickPresetWrapper"
         class="custom-select custom-select-sm"
       >
-        <option v-for="(value, name) in quickPresets" :value="name">
+        <option v-for="(value, name) in quickPresetsComplete" :value="name">
           {{ value.label ?? name }}
         </option>
         <option disabled>custom</option>
diff --git a/frontend/src/variants/components/QueryPresets/SetEditor.vue b/frontend/src/variants/components/QueryPresets/SetEditor.vue
index c3c5f362d..b1406aeef 100644
--- a/frontend/src/variants/components/QueryPresets/SetEditor.vue
+++ b/frontend/src/variants/components/QueryPresets/SetEditor.vue
@@ -250,7 +250,6 @@ const handleAddClicked = async (category) => {
         quality: null,
         chromosome: null,
         flagsetc: null,
-        inheritance: null,
       }
     } else if (category === 'qualitypresets') {
       payload = {
diff --git a/frontend/src/variants/components/QueryPresets/SetQuickPresets.vue b/frontend/src/variants/components/QueryPresets/SetQuickPresets.vue
index 114930447..3af1c2122 100644
--- a/frontend/src/variants/components/QueryPresets/SetQuickPresets.vue
+++ b/frontend/src/variants/components/QueryPresets/SetQuickPresets.vue
@@ -1,6 +1,8 @@
 <script setup>
 /** Editor component for quick presets.
  */
+import { computed } from 'vue'
+
 import { randomString } from '@/varfish/common'
 
 /** Define props. */
@@ -15,11 +17,31 @@ const props = defineProps({
     default: randomString(),
   },
 })
+
+const isIncomplete = computed(() => {
+  for (const key of [
+    'inheritance',
+    'frequency',
+    'impact',
+    'quality',
+    'chromosome',
+    'flagsetc',
+  ]) {
+    if (!props.querySettings[key]) {
+      return true
+    }
+  }
+  return false
+})
 </script>
 
 <template>
   <!-- eslint-disable -->
   <div v-if="querySettings" class="mr-2 mt-2">
+    <div class="alert alert-warning" v-if="isIncomplete">
+      <strong>Warning!</strong> The query settings are incomplete and will not
+      be available in the filter form unless all values are set.
+    </div>
     <div class="form-group">
       <label :for="'inheritance' + idSuffix"> Inheritance </label>
       <select