Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install libsnappy-dev in CI #570

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: install libsnappy-dev in CI #570

merged 1 commit into from
Oct 8, 2024

Conversation

holtgrewe
Copy link
Contributor

@holtgrewe holtgrewe commented Oct 8, 2024

Summary by CodeRabbit

  • New Features
    • Enhanced CI process for Rust projects with additional dependency installations.
    • Added Clippy toolchain component for improved linting.
  • Bug Fixes
    • Improved handling of Git LFS files during repository checkout in CI jobs.

Copy link
Contributor

coderabbitai bot commented Oct 8, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies two GitHub Actions workflow files: .github/workflows/release-please.yml and .github/workflows/rust.yml. In both files, the installation of the libsnappy-dev package has been added alongside librocksdb-dev to enhance the environment setup for the Rust project. Additionally, the Linting job in rust.yml now explicitly mentions the installation of the Clippy toolchain component, and the Checkout repository steps have been updated to include Git LFS support.

Changes

File Path Change Summary
.github/workflows/release-please.yml Added libsnappy-dev installation to the cargo-release job alongside librocksdb-dev.
.github/workflows/rust.yml Updated Linting and Testing jobs to install libsnappy-dev with librocksdb-dev; added Clippy toolchain installation; updated Checkout repository to include lfs: true.

Possibly related PRs

  • ci: install rocksdb dependencies in CI #568: This PR modifies the .github/workflows/release-please.yml and .github/workflows/rust.yml files to include the installation of librocksdb-dev, which is directly related to the changes made in the main PR that added libsnappy-dev alongside librocksdb-dev.

Poem

In the land of code where rabbits play,
New dependencies hop in, brightening the day.
With libsnappy-dev now by our side,
Our Rusty builds will surely glide.
Clippy's here to lend a paw,
Making our code the best of all! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@holtgrewe holtgrewe merged commit 1169479 into main Oct 8, 2024
6 of 7 checks passed
@holtgrewe holtgrewe deleted the ci-fix-snappy branch October 8, 2024 11:31
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.01%. Comparing base (6d7c1c4) to head (1603cfb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   74.01%   74.01%           
=======================================
  Files          26       26           
  Lines        9857     9857           
=======================================
  Hits         7296     7296           
  Misses       2561     2561           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant