Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: storing TSV lines as string to reduce storage size (#57) #58

Merged
merged 1 commit into from
Jun 1, 2023
Merged

feat: storing TSV lines as string to reduce storage size (#57) #58

merged 1 commit into from
Jun 1, 2023

Conversation

holtgrewe
Copy link
Contributor

No description provided.

@holtgrewe holtgrewe linked an issue May 31, 2023 that may be closed by this pull request
Tune CADD output size #57
Open
@holtgrewe holtgrewe marked this pull request as draft May 31, 2023 14:34
@holtgrewe
Copy link
Contributor Author

Converting this to draft as I'm running the CADD conversion with the changed code overnight to see whether we get a reduction in size.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.07 ⚠️

Comparison is base (986d452) 89.26% compared to head (f824941) 89.19%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   89.26%   89.19%   -0.07%     
==========================================
  Files          31       31              
  Lines        3185     3185              
==========================================
- Hits         2843     2841       -2     
- Misses        342      344       +2
Impacted Files Coverage Δ
src/tsv/cli/import/mod.rs 87.30% <50.00%> (-0.20%) ⬇️
src/tsv/cli/query.rs 94.44% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@holtgrewe holtgrewe mentioned this pull request Jun 1, 2023
Open
@holtgrewe holtgrewe marked this pull request as ready for review June 1, 2023 06:45
@holtgrewe holtgrewe merged commit 3a77eb6 into main Jun 1, 2023
@holtgrewe holtgrewe deleted the 57-tune-cadd-output-size branch June 1, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tune CADD output size
1 participant
@holtgrewe