Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automaticTax parameter to Session.create #147

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

winsmith
Copy link
Contributor

@winsmith winsmith commented Jan 2, 2022

Fixes #145

@winsmith winsmith marked this pull request as draft January 2, 2022 11:48
@winsmith winsmith marked this pull request as ready for review January 2, 2022 12:01
@winsmith
Copy link
Contributor Author

Hey, just noticed that this PR is kinda languishing and figured maybe there's something I need to do that I haven't already. Is there anything I can do to help? I could ask for reviews on Twitter, or maybe I'm not fulfilling a requirement that I'm not aware of.

Copy link

@martinlasek martinlasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it by creating a checkout session with and without.
This PR looks good.

@gwynne gwynne merged commit 211a1fe into vapor-community:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support automatic_tax parameter when creating Session
4 participants