Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the consumer from loading images that are too large. #176

Open
willgraf opened this issue Dec 7, 2021 · 0 comments · May be fixed by #179
Open

Prevent the consumer from loading images that are too large. #176

willgraf opened this issue Dec 7, 2021 · 0 comments · May be fixed by #179
Labels
enhancement New feature or request

Comments

@willgraf
Copy link
Contributor

willgraf commented Dec 7, 2021

The consumer has a MAX_IMAGE_HEIGHT, MAX_IMAGE_WIDTH, and MAX_IMAGE_FRAMES to limit the size of the images that are downloaded and opened by consumers. If images are too large, the consumer can get killed due to the memory usage. This can lead to a crash loop, where the consumer is never able to "fail" the image because it is killed to quickly.

The frontend and ImageJ plugin should both attempt to limit the uploading of images that exceed the maximum limits. However, zip file uploads cannot be easily inspected and will require fixes to the consumer itself.


The consumer needs to be able to parse the dimensions of the image prior to loading it, and fail if necessary before consuming the memory.

@willgraf willgraf added the enhancement New feature or request label Dec 7, 2021
@willgraf willgraf linked a pull request Dec 14, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant