You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The gke-helmfile-deployment.sh will parse every helmfile in conf/helmfile.d, looking for the first "name" field it finds which IS NOT preceded by "stable". This is pretty fragile, as if there is a repositories field with a different name (or even stable without quotes), it will pick the repository name instead of the deployment name.
To Reproduce
Edit any helmfile with a repositories field and change the name from "stable" to anything else.
Run the gke-helmfile-deployment.sh script.
Check that it will have failed to deploy that resource (kubectl get po).
Expected behavior
helmfiles should be deployed even if they have a repository name that is not "stable".
Additional context
This was discovered when attempting to upgrade the redis helm chart to the bitnami helm repo. This seems like a good opportunity to fix the script and tackle #206
The text was updated successfully, but these errors were encountered:
Describe the bug
The
gke-helmfile-deployment.sh
will parse every helmfile inconf/helmfile.d
, looking for the first"name"
field it finds which IS NOT preceded by"stable"
. This is pretty fragile, as if there is arepositories
field with a different name (or evenstable
without quotes), it will pick the repository name instead of the deployment name.To Reproduce
repositories
field and change thename
from"stable"
to anything else.gke-helmfile-deployment.sh
script.kubectl get po
).Expected behavior
helmfiles should be deployed even if they have a repository name that is not
"stable"
.Additional context
This was discovered when attempting to upgrade the
redis
helm chart to the bitnami helm repo. This seems like a good opportunity to fix the script and tackle #206The text was updated successfully, but these errors were encountered: