Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CI/CD #176

Closed
dylanbannon opened this issue Sep 14, 2019 · 6 comments
Closed

Implement CI/CD #176

dylanbannon opened this issue Sep 14, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@dylanbannon
Copy link
Contributor

We need some sort of automated testing for this project.

@dylanbannon dylanbannon added the enhancement New feature or request label Sep 14, 2019
@osterman
Copy link
Contributor

Signup for GitHub actions for your org. This will be perfect for you guys.

@osterman
Copy link
Contributor

https://github.com/features/actions/signup/?account=osterman

When you signup, make sure you select the “vanvalenlab” in the drop down.

@MekWarrior
Copy link
Collaborator

#198 uses automated builds but does not include tests. If required we can migrate off travis.

@willgraf
Copy link
Contributor

willgraf commented Jan 17, 2020

This looks to be a duplicate of #60. I will close the older issue as the discussion here is a bit more helpful.


The most helpful comment from the previous issue:

Upon @osterman's suggestion, we'll be implementing tests using https://github.com/bats-core/bats-core

Specific things to test (feel free to expand):

  • cluster creation on both AWS and GKE
  • GPU scale-up for both predict and training jobs on both AWS and GKE

@dylanbannon
Copy link
Contributor Author

dylanbannon commented Mar 3, 2020

We have a bare bones integration testing framework in #268. Further work on integration testing is occurring in #281, so I'll consider the current issue closed.

This close is a nice one, since the issue is so old and everyone worked on the resolution. Great work!

@dylanbannon dylanbannon mentioned this issue Mar 4, 2020
4 tasks
@dylanbannon
Copy link
Contributor Author

Closed by #268!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants