Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML5 Video Tag #29

Closed
paradoxondev opened this issue Nov 3, 2020 · 6 comments
Closed

HTML5 Video Tag #29

paradoxondev opened this issue Nov 3, 2020 · 6 comments
Labels
incompatible service Reports for services, that are currently incompatible with Skip Silence

Comments

@paradoxondev
Copy link

paradoxondev commented Nov 3, 2020

What service is not compatible? (e.g. "Vimeo"): HTML5 Video Tag

Can you provide a link to a specific video where this has occurred? (i.e. can you provide the link where this happend?): every video opened direct in the browser

What is the exact problem that occurred? (e.g. "No sound detected" or "No video detected/icon is not green"): No video detected

What version of Skip Silence are you using? (i.e. 1, 2 or 3. You can find this information by opening the popup, it should be right in the title): 3

Problem is probably caused by having a source tag within an video tag instead of a src attribute.

@paradoxondev paradoxondev added the incompatible service Reports for services, that are currently incompatible with Skip Silence label Nov 3, 2020
@vantezzen
Copy link
Owner

Cannot reproduce. I've used this code:

<video controls>
      <source src="test.mp4" type="video/mp4">
</video>

and it works.

@pal03377
Copy link

pal03377 commented Nov 5, 2020

I can reproduce this... Here is a nicer description of how to do it

  1. Install Skip Silence in a fresh Chrome browser via the Chrome Web Store
  2. Open https://commondatastorage.googleapis.com/gtv-videos-bucket/sample/ElephantsDream.mp4
  3. Click the extension
  4. No audio is displayed and silence is not skipped.

Here's what it looks like for me: https://i.imgur.com/Fu2GQwb.mp4

@vantezzen
Copy link
Owner

vantezzen commented Nov 6, 2020

Very interesting, still can't reproduce it with the exact link you provided: https://imgur.com/a/U7XsuGP

Could you please open the console to see if there are any errors thrown by the extension?

@pal03377
Copy link

pal03377 commented Nov 6, 2020

Wow, that's really strange 🤔

There are no error logs in the console:
image

I'll try to download and install the development version from the repository now and see if I can get more info out of this.

@pal03377
Copy link

pal03377 commented Nov 6, 2020

Heyy, I fixed it and it now works locally! The extension didn't search for media elements, as DOMContentLoaded event was already fired before it was loaded and the check about whether the event was already fired was incomplete. I completed it in this PR.

@vantezzen
Copy link
Owner

Thank you for researching this and making the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible service Reports for services, that are currently incompatible with Skip Silence
Projects
None yet
Development

No branches or pull requests

3 participants