Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ESBuild #1252

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Conversation

Ethan-PageUp
Copy link
Contributor

ESBuild version 0.17.6 was found to be causing issues with some of our components being rendered.

Upgrading to 0.19.9 to prevent anyone else from spending days debugging (and to stop us needing to delete the node_modules inside our vanilla-extract dependency 😆 )

Copy link

changeset-bot bot commented Dec 13, 2023

🦋 Changeset detected

Latest commit: 01d3553

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vanilla-extract/jest-transform Patch
@vanilla-extract/integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BenBeattieHood
Copy link

esbuild added support for the TS const keyword in generic params earlier this year. This PR updates esbuild to a version that supports this, so that vanilla-extract can be run in repos using this newer syntax.

@BenBeattieHood
Copy link

@Ethan-PageUp It might be more preferable to make esbuild a peerDependency in only the integration and jest-integration plugins rather than upgrading the version in all packages here. This would allow consumers to set their own version of esbuild to use, rather than it being defined explicitly by vanilla-extract. See here how esbuild-plugin does it for an example.

@askoufis
Copy link
Contributor

Thanks for the PR. We've been hesitant to upgrade the esbuild version too hastily as it has caused issues in the past. We'll take a look at upgrading the version if it seems appropriate. Support for const in generics would be nice.

@@ -18,14 +18,14 @@
"@vanilla-extract/integration": "^6.2.0"
},
"peerDependencies": {
"esbuild": ">=0.17.6"
"esbuild": ">=0.19.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause a major version bump, which we don't really want. The plugin works with >=0.17.6, so we'll leave it as-is.

@mrm007
Copy link
Contributor

mrm007 commented Jan 25, 2024

Thanks @Ethan-PageUp! I made a few changes to reduce the impact and avoid breaking changes.

@mrm007 mrm007 merged commit 5bc98a4 into vanilla-extract-css:master Jan 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants