Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: close response body #1496

Merged
merged 1 commit into from
Feb 15, 2023
Merged

test: close response body #1496

merged 1 commit into from
Feb 15, 2023

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Feb 15, 2023 •
edited
Loading

This PR fixes missing calls to Response.Body.Close() in tests. Also, enable bodyclose linter that detects such issues.

@erikdubbelboer erikdubbelboer merged commit b79a03a into valyala:master Feb 15, 2023
@erikdubbelboer
Copy link
Collaborator

Thanks! Great addition.

@alexandear alexandear deleted the test-fix-bodyclose branch February 15, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @erikdubbelboer