Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename unexported funcs, vars to match common Go #1488

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Rename unexported funcs, vars to match common Go #1488

merged 1 commit into from
Feb 10, 2023

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Feb 10, 2023

This PR makes stylistic changes in internal code. It renames unexported functions and variables to match the common Go style:

  • cancel_ctx -> cancelCtx
  • svrUrl -> srvUrl (should be srv from server, not svr)
  • isHttps -> isHTTPS
  • isHttp -> isHTTP
  • isIp6 -> isIP6
  • isIp6WithoutPort -> isIP6WithoutPort

See https://github.com/golang/go/wiki/CodeReviewComments#initialisms and https://go.dev/doc/effective_go#mixed-caps.

@erikdubbelboer erikdubbelboer merged commit f84e234 into valyala:master Feb 10, 2023
@erikdubbelboer
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants