Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve and display Valtimo frontend/backend versions dynamically #1314

Open
sjorsholtrop-ritense opened this issue Dec 31, 2024 · 3 comments

Comments

@sjorsholtrop-ritense
Copy link

The frontend/backend versions displayed in the UI here are incorrect:
Screenshot 2024-12-31 at 13 43 22
(this was frontend and backend both v12.5.1)

This is because these versions are hardcoded in https://github.com/valtimo-platform/valtimo-frontend-libraries/blob/next-minor/projects/valtimo/config/src/lib/constants/versions.ts. We need a reliable source for these version numbers. Maybe an env variable that's set in CI?

@Hildebrand-Ritense
Copy link
Contributor

Hildebrand-Ritense commented Dec 31, 2024

This should be managed by https://github.com/valtimo-platform/valtimo-frontend-libraries/blob/next-minor/scripts/copy-frontend-version.js
But I guess something went wrong here.

Using envvars is not an option here, the files aren't processed before being served. That's the point of a static frontend. That's why they're copied from upstream to the implementation downstream. I assume this npm run copy-frontend-version might have been skipped in the Valtimo Cloud GitHub actions workflow.

@Hildebrand-Ritense
Copy link
Contributor

Maybe related, since you're using 12.5.1. It seems the publishing build might not have ran as it should.

@sjorsholtrop-ritense
Copy link
Author

Ah, I forgot to mention: This is when running locally. The Docker image has the correct versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants