Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to avoid trading once when stop trading is set to true, or KPI staking conditions are met #246

Open
jmoreira-valory opened this issue Apr 11, 2024 · 0 comments
Labels
bug Something isn't working refactor

Comments

@jmoreira-valory
Copy link
Collaborator

jmoreira-valory commented Apr 11, 2024

As explained in #245, due to the current implementation of the trader, it requires significant refactor to skip directly to the RedeemRound when the Trader is started.

A quick solution was implement (on that PR) the fact that the trader must always execute the "full trading path" at least once (for the first period). Then it can skip trading.

This has the implication that the trader needs to through the full bet cycle at least once (even if disable_trading=true or staking KPI conditions are met), which will incur in making one mech request (and placing the bet if it deems it's profitable).

@jmoreira-valory jmoreira-valory added bug Something isn't working refactor labels Apr 12, 2024
@jmoreira-valory jmoreira-valory changed the title Refactor to avoid trading once when stop trading KPI staking conditions are made Refactor to avoid trading once when stop trading is set to true, or KPI staking conditions are met Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor
Projects
None yet
Development

No branches or pull requests

1 participant