fix(tests): "no provider" error when running tests

[Igonato]

Fix for #929

Seems like DI derps in the test environment and not able to resolve providers using the new NgModule system. For tests to pass components need to have providers field.

[codecov-io]

Current coverage is 90.39% (diff: 100%)

Merging #963 into development will not change coverage

@@           development       #963   diff @@
=============================================
  Files               26         26          
  Lines              781        781          
  Methods            142        142          
  Messages             0          0          
  Branches           115        115          
=============================================
  Hits               706        706          
  Misses              75         75          
  Partials             0          0          

Powered by Codecov. Last update 6effd07...b0f1b40

[Martin-Luft]

@Igonato why is this not needed for datepicker-popup.component (I think this component is dead code), button-checkbox.directive and button-radio.directive? This components and directives also have the ngModel selector binding...? Or are directives not affected?

[otelnov]

There is "imports" param in TestBed.configureTestingModule where you can pass FormsModule or whatever you need.

[Martin-Luft]

@otelnov this is not working, please see the related issue.

[Igonato]

@Martin-Wegner I don't see any datepicker-popup.component what branch are you on?

As for the others what I did is I imported every ng2-bootstrap module and specified providers field for components that would fail the tests. Test DI doesn't fail for every component nor for every provider, so far it only does so with NgModel and some components. My guess is that some circular dependency needs to happen that can be resolved in the browser but not in testing.

[valorkin]

@Igonato I have dropped it completely (datepicker-popup.component ) until it is working properly

[Igonato]

@valorkin what was/is wrong with it?

And what do you think about this PR? Did you review the changes, any comments?

[valorkin]

as temporary solution should work, but will have to find more generic solution later

@Igonato thanks for your time! :)