Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): added new config property keepDatesOutOfRules #6554

Conversation

SvetlanaMuravlova
Copy link
Contributor

@SvetlanaMuravlova SvetlanaMuravlova commented Feb 3, 2023

feat(datepicker): added new config property keepDatesOutOfRules
close #6085 #6066 #6021 #5764 #5738

@SvetlanaMuravlova SvetlanaMuravlova self-assigned this Feb 3, 2023
This reverts commit c492fe5.
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Visit the preview URL for this PR (updated for commit dc7f669):

https://ngx-bootstrap-demo--pr6554-add-datepicker-confi-kikmpstg.web.app

(expires Sun, 12 Feb 2023 07:05:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ad45a8e01b9a4306733c914c8a4d7c9337cc4d07

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #6554 (dc7f669) into development (663c70e) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6554      +/-   ##
===============================================
- Coverage        76.98%   76.95%   -0.04%     
===============================================
  Files              315      315              
  Lines            10701    10704       +3     
  Branches          2988     2990       +2     
===============================================
- Hits              8238     8237       -1     
- Misses            2461     2465       +4     
  Partials             2        2              
Impacted Files Coverage Δ
src/datepicker/bs-datepicker.component.ts 80.53% <100.00%> (+0.13%) ⬆️
src/datepicker/bs-datepicker.config.ts 100.00% <100.00%> (ø)
src/datepicker/bs-daterangepicker.component.ts 82.43% <100.00%> (+0.11%) ⬆️
src/chronos/i18n/pl.ts 81.96% <0.00%> (-3.28%) ⬇️
src/chronos/i18n/sk.ts 85.00% <0.00%> (-2.50%) ⬇️
src/chronos/i18n/cs.ts 87.36% <0.00%> (-2.11%) ⬇️
src/chronos/i18n/uk.ts 90.62% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663c70e...dc7f669. Read the comment docs.

@cypress
Copy link

cypress bot commented Feb 3, 2023

36 failed tests on run #3858 ↗︎

36 802 14 0 Flakiness 0

Details:

Merge dc7f669 into 663c70e...
Project: ngx-bootstrap Commit: d558a06951 ℹ️
Status: Failed Duration: 34:01 💡
Started: Feb 5, 2023 7:07 AM Ended: Feb 5, 2023 7:41 AM
Failed  datepicker/locales_spec.ts • 2 failed tests • full

View Output Video

Test
Datepicker demo testing suite: Locales > Change Locale Datepicker > when user chose locale es-pr for "Datepicker", container shown in appropriate language Screenshot
Datepicker demo testing suite: Locales > Change Locale DateRangepicker > when user chose locale es-pr for "Daterangepicker", container shown in this language Screenshot
Failed  modals_service_page_spec.ts • 13 failed tests • full

View Output Video

Test
Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "Close" button, triggers the interceptor and doesn't close the modal Screenshot
Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "Yes" button, closes the modal Screenshot
Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "No" button, doesn't close the modal Screenshot
Modals demo page testing suite: Service examples > Nested modals > when user clicks on the button "Open second modal" then the second modal with title "Second modal" is opened, "Close self" is present Screenshot
Modals demo page testing suite: Service examples > Events > when user closes modal by click on the cross then should be messages "onHide event has been fired" and "onHidden event has been fired" Screenshot
Modals demo page testing suite: Service examples > Events > when user closes modal by pressing ESC button then modal is closed and should be messages "onHide event has been fired" and "onHidden event has been fired" Screenshot
Modals demo page testing suite: Service examples > Confirm Window > when user clicks on "Open modal" button then modal is opened, it contains two buttons: "Yes" and "No" Screenshot
Modals demo page testing suite: Service examples > Custom css class > when user clicks on the cross button then the modal is closed Screenshot
Modals demo page testing suite: Service examples > Animation option > when user clicks on the cross button then the modal is closed Screenshot
Modals demo page testing suite: Service examples > Esc closing option > when user clicks on "Open modal" button then modal is opened. when user closes modal by click ESC button then modal stays opened Screenshot
The first 10 failed tests are shown, see all 13 tests in Cypress Cloud.
Failed  typeahead_page_spec.ts • 1 failed test • full

View Output Video

Test
Typeahead demo page testing suite > On blur > clicking anywhere outside auto-fills "Option on blur" with the first option from the matches list Screenshot
Failed  popover_page_spec.ts • 1 failed test • full

View Output Video

Test
Popover demo page testing suite > Component level styling > when user clicks on "I have component level styling", then popover-container appear above the button Screenshot
Failed  tabs_page_spec.ts • 1 failed test • full

View Output Video

Test
Tabs demo page spec > Dynamic tabs > when user clicks on close icon near tab, then this tab removed Screenshot

The first 5 failed specs are shown, see all 13 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link

@Alexveselun Alexveselun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing completed. No critical issues were found

@valorkin valorkin merged commit 1cd4ae1 into development Feb 8, 2023
@valorkin valorkin deleted the add-datepicker-config-property-avoid-overwrite-out-ranges branch February 8, 2023 19:03
@VirendraMaheta7
Copy link

Visit the preview URL for this PR (updated for commit dc7f669):

https://ngx-bootstrap-demo--pr6554-add-datepicker-confi-kikmpstg.web.app

(expires Sun, 12 Feb 2023 07:05:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ad45a8e01b9a4306733c914c8a4d7c9337cc4d07

The preview URL for this PR is not working, can you please share updated working URL (demo with code)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datepicker input automatically changes the displayed value
4 participants