Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): fixed disabled state on datepickers #6540

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

SvetlanaMuravlova
Copy link
Contributor

@SvetlanaMuravlova SvetlanaMuravlova commented Dec 20, 2022

close #6471
close #6487

@SvetlanaMuravlova SvetlanaMuravlova changed the title Datepicker disabled fix(datepicker): fixed disabled state on datepickers Dec 20, 2022
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 04191e7):

https://ngx-bootstrap-demo--pr6540-datepicker-disabled-67kshr7i.web.app

(expires Tue, 27 Dec 2022 16:26:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ad45a8e01b9a4306733c914c8a4d7c9337cc4d07

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #6540 (04191e7) into development (7e085f9) will increase coverage by 0.06%.
The diff coverage is 93.75%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6540      +/-   ##
===============================================
+ Coverage        76.77%   76.84%   +0.06%     
===============================================
  Files              315      315              
  Lines            10639    10662      +23     
  Branches          2963     2972       +9     
===============================================
+ Hits              8168     8193      +25     
+ Misses            2469     2467       -2     
  Partials             2        2              
Impacted Files Coverage Δ
src/datepicker/themes/bs/bs-datepicker-view.html 100.00% <ø> (ø)
...icker/themes/bs/bs-days-calendar-view.component.ts 21.53% <ø> (ø)
...emes/bs/bs-datepicker-navigation-view.component.ts 69.23% <33.33%> (-10.77%) ⬇️
src/datepicker/bs-datepicker.component.ts 77.69% <100.00%> (+1.53%) ⬆️
src/datepicker/bs-daterangepicker.component.ts 78.74% <100.00%> (+1.57%) ⬆️
...ker/themes/bs/bs-datepicker-container.component.ts 87.12% <100.00%> (+0.81%) ⬆️
...mes/bs/bs-datepicker-inline-container.component.ts 100.00% <100.00%> (ø)
...hemes/bs/bs-daterangepicker-container.component.ts 74.48% <100.00%> (+1.10%) ⬆️
...s/bs-daterangepicker-inline-container.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e085f9...04191e7. Read the comment docs.

@cypress
Copy link

cypress bot commented Dec 20, 2022



Test summary

797 35 14 0


Run details

Project ngx-bootstrap
Status Failed
Commit 3b6d7a1 ℹ️
Started Dec 20, 2022 4:28 PM
Ended Dec 20, 2022 5:05 PM
Duration 37:05 💡
OS Linux Ubuntu - 22.04
Browser Electron 100

View run in Cypress Dashboard ➡️


Failures

datepicker/locales_spec.ts Failed
1 Datepicker demo testing suite: Locales > Change Locale Datepicker > when user chose locale es-pr for "Datepicker", container shown in appropriate language
2 Datepicker demo testing suite: Locales > Change Locale DateRangepicker > when user chose locale es-pr for "Daterangepicker", container shown in this language
modals_service_page_spec.ts Failed
1 Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "Close" button, triggers the interceptor and doesn't close the modal
2 Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "Yes" button, closes the modal
3 Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "No" button, doesn't close the modal
4 Modals demo page testing suite: Service examples > Nested modals > when user clicks on the button "Open second modal" then the second modal with title "Second modal" is opened, "Close self" is present
5 Modals demo page testing suite: Service examples > Events > when user closes modal by click on the cross then should be messages "onHide event has been fired" and "onHidden event has been fired"
6 Modals demo page testing suite: Service examples > Events > when user closes modal by pressing ESC button then modal is closed and should be messages "onHide event has been fired" and "onHidden event has been fired"
7 Modals demo page testing suite: Service examples > Confirm Window > when user clicks on "Open modal" button then modal is opened, it contains two buttons: "Yes" and "No"
8 Modals demo page testing suite: Service examples > Custom css class > when user clicks on the cross button then the modal is closed
This comment includes only the first 10 test failures. See all 35 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link

@Alexveselun Alexveselun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing completed. No critical issues were found

@valorkin valorkin merged commit 818e889 into development Dec 21, 2022
@valorkin valorkin deleted the datepicker-disabled branch December 21, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants