Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timepicker): fixed reset validation for ngModel #6294

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

SvetlanaMuravlova
Copy link
Contributor

fix(timepicker): fixed reset validation for ngModel
close #6038

@SvetlanaMuravlova SvetlanaMuravlova added this to the 2021-09-17 milestone Sep 14, 2021
@valorkin valorkin temporarily deployed to ngx-bootstra-fix-timepi-20s9l5 September 14, 2021 08:19 Inactive
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit cfc1226):

https://ngx-bootstrap-demo--pr6294-fix-timepicker-model-4kgsgr2m.web.app

(expires Tue, 21 Sep 2021 08:23:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #6294 (cfc1226) into development (cf5272f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6294   +/-   ##
============================================
  Coverage        77.27%   77.27%           
============================================
  Files              311      311           
  Lines            10714    10715    +1     
  Branches          2639     2639           
============================================
+ Hits              8279     8280    +1     
  Misses            2425     2425           
  Partials            10       10           
Impacted Files Coverage Δ
src/timepicker/timepicker.component.ts 92.98% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5272f...cfc1226. Read the comment docs.

@cypress
Copy link

cypress bot commented Sep 14, 2021



Test summary

813 17 14 0


Run details

Project ngx-bootstrap
Status Failed
Commit 3d2f58b ℹ️
Started Sep 14, 2021 8:24 AM
Ended Sep 14, 2021 8:37 AM
Duration 12:24 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Failures

modals_service_page_spec.ts Failed
1 Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "Close" button, triggers the interceptor and doesn't close the modal
2 Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "Yes" button, closes the modal
3 Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "No" button, doesn't close the modal
4 Modals demo page testing suite: Service examples > Events > when user closes modal by pressing ESC button then modal is closed and should be messages "onHide event has been fired" and "onHidden event has been fired"
carousel_page_spec.ts Failed
1 Carousel page testing suite > Slide changed event > example contains slides, indicators, left and right controls and "Slide has been switched: 0"
2 Carousel page testing suite > Slide changed event > when user click on left arrow - info changed to "Slide has been switched: 2"
3 Carousel page testing suite > Slide changed event > when user click on left arrow again - info changed to "Slide has been switched: 1"
4 Carousel page testing suite > Slide changed event > when user click on right arrow - info changed to "Slide has been switched: 1"
5 Carousel page testing suite > Slide changed event > when user click on right arrow again - info changed to "Slide has been switched: 2"
pagination_page_spec.ts Failed
1 Pagination demo page testing suite > Pager > example contains: 7 pages, Next - active, Previous - active, 4th page active
This comment includes only the first 10 test failures. See all 17 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@valorkin valorkin merged commit d777be6 into development Sep 21, 2021
@valorkin valorkin deleted the fix-timepicker-model-validation branch September 21, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timepicker Dynamic Fails removing red error border when valid date is applyed to ngmodel
3 participants