Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): fix next ver issue with moduleWithProviders #5812

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

daniloff200
Copy link
Contributor

@daniloff200 daniloff200 commented Jun 9, 2020

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

Description

Fixes error in next version (Angular 10 pre-releases):

Building collapse module
Error: Command failed: /bin/sh -c rimraf dist/collapse && node scripts/ng-packagr/api ../../src/collapse/package.json
ERROR: src/collapse/collapse.module.ts:10:21 - error TS2314: Generic type 'ModuleWithProviders<T>' requires 1 type argument(s).
10   static forRoot(): ModuleWithProviders {
                       ~~~~~~~~~~~~~~~~~~~
Error: src/collapse/collapse.module.ts:10:21 - error TS2314: Generic type 'ModuleWithProviders<T>' requires 1 type argument(s).
10   static forRoot(): ModuleWithProviders {
                       ~~~~~~~~~~~~~~~~~~~
    at Object.<anonymous> (/home/travis/build/valor-software/ngx-bootstrap/node_modules/ng-packagr/lib/ngc/compile-source-files.js:82:19)
    at Generator.next (<anonymous>)
    at fulfilled (/home/travis/build/valor-software/ngx-bootstrap/node_modules/ng-packagr/lib/ngc/compile-source-files.js:5:58)
Building Angular Package

related to angular/angular#36892

@daniloff200 daniloff200 requested a review from valorkin June 9, 2020 09:03
@daniloff200 daniloff200 force-pushed the fix-module-with-providers-next branch from ad305b5 to 59f27e2 Compare June 9, 2020 11:32
@daniloff200 daniloff200 force-pushed the fix-module-with-providers-next branch from 59f27e2 to 796311b Compare June 9, 2020 11:54
@valorkin valorkin merged commit e2ef559 into development Jun 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-module-with-providers-next branch June 9, 2020 14:06
@CemAltel
Copy link

When will this change be released? The 5.6.2 version causes a compilation error with Angular 10.

@CemAltel CemAltel mentioned this pull request Jun 29, 2020
@gmaggiodev
Copy link

As workaround, waiting for release (#5831 (comment))

@pavankjadda
Copy link

pavankjadda commented Jul 1, 2020

@gmaggiodev I see latest tag 5.7.0 in Github but NPM has latest version 5.6.1? Why is that? Is it publishing error? And also I see 5.7.0 and 5.6.1 as tags but not releases in Github.

@gmaggiodev
Copy link

@pavankjadda I think it is yet in development branch. So, still not available, from my understanding.

image

@azherf
Copy link

azherf commented Jul 6, 2020

Hey, just checking out if there is any update on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants