Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typeahead): add typing for typeahead source data #5647

Merged

Conversation

IraErshova
Copy link
Contributor

@IraErshova IraErshova commented Feb 6, 2020

Add typing for typeahead source data

Please merge only after this PR #5646

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #5647 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5647   +/-   ##
============================================
  Coverage        52.52%   52.52%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                52       52           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d80bdfd...1df1fcc. Read the comment docs.

@dmitry-zhemchugov
Copy link
Contributor

Needs change name of Demo like in the previous PR: #5646

@daniloff200
Copy link
Contributor

@dmitry-zhemchugov this PR was based on branch from 5646, so, as soon, as 5646 will be merged, conflicts will be resolved, and everything will be the same

Add typing for typeahead source data
@daniloff200 daniloff200 merged commit 26aff71 into valor-software:development Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants