Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): api-doc add compatibility typescript 3 #4732

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Oct 24, 2018

compatible with typescript 2.7.2 and more

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost assigned Domainv Oct 24, 2018
@ghost ghost added the needs review label Oct 24, 2018
@codecov
Copy link

codecov bot commented Oct 24, 2018

Codecov Report

Merging #4732 into development will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4732      +/-   ##
===============================================
- Coverage        74.34%   74.31%   -0.03%     
===============================================
  Files              202      202              
  Lines             7102     7102              
  Branches          1447     1447              
===============================================
- Hits              5280     5278       -2     
- Misses            1425     1427       +2     
  Partials           397      397
Impacted Files Coverage Δ
src/chronos/i18n/pl.ts 72.22% <0%> (-2.78%) ⬇️
src/chronos/i18n/sk.ts 80.85% <0%> (-2.13%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (-1.7%) ⬇️
src/chronos/i18n/uk.ts 80.48% <0%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e967f...928bb0a. Read the comment docs.

@valorkin valorkin merged commit d5de6dd into development Oct 24, 2018
@delete-merged-branch delete-merged-branch bot deleted the feat-api-doc-add-compatibility-typescript3 branch October 24, 2018 16:32
@ghost ghost removed the needs review label Oct 24, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants